[libcamera-devel] [PATCH v8 1/7] Allow inheritance of FrameBuffer

Harvey Yang chenghaoyang at chromium.org
Wed Dec 14 10:33:24 CET 2022


From: Harvey Yang <chenghaoyang at chromium.org>

To add buffer_handle_t access in android, this patch allows inheritance
of FrameBuffer to add a derived class in android.

Signed-off-by: Harvey Yang <chenghaoyang at chromium.org>
Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>
Reviewed-by: Han-Lin Chen <hanlinchen at chromium.org>
---
 include/libcamera/framebuffer.h | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/include/libcamera/framebuffer.h b/include/libcamera/framebuffer.h
index 69553999..61244829 100644
--- a/include/libcamera/framebuffer.h
+++ b/include/libcamera/framebuffer.h
@@ -46,7 +46,7 @@ private:
 	std::vector<Plane> planes_;
 };
 
-class FrameBuffer final : public Extensible
+class FrameBuffer : public Extensible
 {
 	LIBCAMERA_DECLARE_PRIVATE()
 
@@ -60,6 +60,7 @@ public:
 
 	FrameBuffer(const std::vector<Plane> &planes, unsigned int cookie = 0);
 	FrameBuffer(std::unique_ptr<Private> d);
+	virtual ~FrameBuffer() {}
 
 	const std::vector<Plane> &planes() const;
 	Request *request() const;
-- 
2.39.0.rc1.256.g54fd8350bd-goog



More information about the libcamera-devel mailing list