[libcamera-devel] [PATCH] utils: checkstyle.py: Check new header file on new and renamed meson.build files

Xavier Roumegue xavier.roumegue at oss.nxp.com
Wed Dec 14 17:16:56 CET 2022


Declaration of new header file to the build system are only checked against
modified meson.build file. Therefore, this raises a false positive warning in
case the meson.build is added or renamed.

Add the new and renamed meson.build files to the list of files to check header
file inclusion.

Signed-off-by: Xavier Roumegue <xavier.roumegue at oss.nxp.com>
---
 utils/checkstyle.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/utils/checkstyle.py b/utils/checkstyle.py
index f0248d65..64dcf5ed 100755
--- a/utils/checkstyle.py
+++ b/utils/checkstyle.py
@@ -313,7 +313,7 @@ class HeaderAddChecker(CommitChecker):
     def check(cls, commit, top_level):
         issues = []
 
-        meson_files = [f for f in commit.files('M')
+        meson_files = [f for f in commit.files('AMR')
                        if os.path.basename(f) == 'meson.build']
 
         for filename in commit.files('AR'):
-- 
2.38.1



More information about the libcamera-devel mailing list