[libcamera-devel] [PATCH v4 1/2] libcamera: Declare generic converter interface

[Kieran Bingham]

Quoting Kieran Bingham (2022-12-14 16:25:27)
> > > >> --- src/libcamera/converter/converter_v4l2_m2m.cpp
> > > >> +++ src/libcamera/converter/converter_v4l2_m2m.cpp
> > > >> @@ -19,7 +21,6 @@
> > > >>
> > > >>   #include "libcamera/internal/media_device.h"
> > > >>   #include "libcamera/internal/v4l2_videodevice.h"
> > > >> -#include "libcamera/internal/converter/converter_v4l2_m2m.h"
> > > >>
> > > > 
> > > > This looks like clang-format moving the line, but checkstyle not quite
> > > > realising where it went...
> > > > 
> > > > You can run clang-format directly to see what it did I think.
> > > Ok, applied the clang-format fix inplace
> > 
> > Great. 
> 
> Oh! Now I see the patch, this was bad advice from me. The
> convertor_v4l2_m2m.h is the interface header for this compile unit. That
> always goes first, but I can't figure out how to tell clang-format that
> when the .h headers are not located next to the .cpp file ... so it
> doesn't know that it's supposed to be first.
> 
> I'll fix this while applying, and get this series in.

FTR: I was confused above, and misread the diff between the version. v5
was/is absolutely fine! (and I've merged it).

--
Kieran