[libcamera-devel] [PATCH v2] Expose the Request Sequence Number in Python Bindings

[Tomi Valkeinen]

On 19/12/2022 15:20, Kieran Bingham wrote:
> From: Matthew Goodman <matt at exclosure.io>
> 
> The python bindings are missing the ability to read the sequence number
> of the Request object from the public API.
> 
> Expose the objects sequence number on the pybind11 surfaces to support
> applications reading this value.
> 
> Signed-off-by: Matthew Goodman <matt at exclosure.io>
> [Kieran: Revised commit message]
> Reviewed-by: Kieran Bingham <kieran.bingham at ideasonboard.com>
> Signed-off-by: Kieran Bingham <kieran.bingham at ideasonboard.com>
> 
> ---
> v2:
>   - Revised commit message.
> 
> Signed-off-by: Kieran Bingham <kieran.bingham at ideasonboard.com>
> 
>   src/py/libcamera/py_main.cpp | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/src/py/libcamera/py_main.cpp b/src/py/libcamera/py_main.cpp
> index 75947889f7b1..d14e18e25f3f 100644
> --- a/src/py/libcamera/py_main.cpp
> +++ b/src/py/libcamera/py_main.cpp
> @@ -335,6 +335,7 @@ PYBIND11_MODULE(_libcamera, m)
>   		.def_property_readonly("status", &Request::status)
>   		.def_property_readonly("buffers", &Request::buffers)
>   		.def_property_readonly("cookie", &Request::cookie)
> +		.def_property_readonly("sequence", &Request::sequence)
>   		.def_property_readonly("has_pending_buffers", &Request::hasPendingBuffers)
>   		.def("set_control", [](Request &self, const ControlId &id, py::object value) {
>   			self.controls().set(id.id(), pyToControlValue(value, id.type()));

Reviewed-by: Tomi Valkeinen <tomi.valkeinen at ideasonboard.com>

  Tomi