[libcamera-devel] [PATCHv2] Simple typo fixes

Kieran Bingham kieran.bingham at ideasonboard.com
Wed Dec 21 14:03:45 CET 2022


Hi Pavel,

How are you sending the patch to the list? It's malformed so it isn't
being picked up as a patch by the patchwork tools.

https://patchwork.libcamera.org/patch/18041/

Are you using git-send-email ? https://git-send-email.io/ helps with the
configuration of that if you are not.

--
Kieran

Quoting Pavel Machek via libcamera-devel (2022-12-20 22:02:35)
> Hi!
> 
> During reading the code, I found some typos that could be fixed.
> 
> Signed-off-by: Pavel Machek <pavel at ucw.cz>
> Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>
> 
> --
> v2: rebased to today's tree.
> 
> commit f214f8fe259b485af926bb6299d07fc17f1272fc
> Author: Pavel Machek <pavel at ucw.cz>
> Date:   Fri Dec 9 18:43:20 2022 +0000
> 
>     cleanup: Fix typos.
> 
> diff --git a/src/ipa/vimc/vimc.cpp b/src/ipa/vimc/vimc.cpp
> index 9256bbba..d5fabaf1 100644
> --- a/src/ipa/vimc/vimc.cpp
> +++ b/src/ipa/vimc/vimc.cpp
> @@ -2,7 +2,7 @@
>  /*
>   * Copyright (C) 2019, Google Inc.
>   *
> - * ipa_vimc.cpp - Vimc Image Processing Algorithm module
> + * vimc.cpp - Vimc Image Processing Algorithm module
>   */
>  #include <libcamera/ipa/vimc_ipa_interface.h>
>  
> diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp
> index eb9ad65c..c27b3ef9 100644
> --- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp
> +++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp
> @@ -220,7 +220,7 @@ RkISP1FrameInfo *RkISP1Frames::create(const RkISP1CameraData *data, Request *req
>                 }
>  
>                 if (pipe_->availableStatBuffers_.empty()) {
> -                       LOG(RkISP1, Error) << "Statisitc buffer underrun";
> +                       LOG(RkISP1, Error) << "Statistic buffer underrun";
>                         return nullptr;
>                 }
>  
> @@ -340,7 +340,7 @@ int RkISP1CameraData::loadIPA(unsigned int hwRevision)
>  
>         /*
>          * The API tuning file is made from the sensor name unless the
> -        * environment variable overrides it. If
> +        * environment variable overrides it.
>          */
>         std::string ipaTuningFile;
>         char const *configFromEnv = utils::secure_getenv("LIBCAMERA_RKISP1_TUNING_FILE");
> 
> -- 
> People of Russia, stop Putin before his war on Ukraine escalates.


More information about the libcamera-devel mailing list