[libcamera-devel] [PATCH] qcam: Show string representation of pixel format

[Christian Rauch]

Hi Kieran,

Am 30.12.22 um 01:25 schrieb Kieran Bingham:
> Quoting Christian Rauch via libcamera-devel (2022-12-29 22:54:35)
>> The raw pixel format in form of the fourcc integer is not easily readable.
>> Use the string representation instead for easier debugging.
>>
>> Signed-off-by: Christian Rauch <Rauch.Christian at gmx.de>
>> ---
>>   src/apps/qcam/viewfinder_qt.cpp | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/src/apps/qcam/viewfinder_qt.cpp b/src/apps/qcam/viewfinder_qt.cpp
>> index a7482bea..dcb7acdf 100644
>> --- a/src/apps/qcam/viewfinder_qt.cpp
>> +++ b/src/apps/qcam/viewfinder_qt.cpp
>> @@ -71,7 +71,7 @@ int ViewFinderQt::setFormat(const libcamera::PixelFormat &format, const QSize &s
>>
>>                  image_ = QImage(size, QImage::Format_RGB32);
>>
>> -               qInfo() << "Using software format conversion from" << format;
>> +               qInfo() << "Using software format conversion from" << format.toString().c_str();
>
> Does the 'conversion from" need a space after it? or does the
> format.toString() provide that?

toString() does not provide the extra space. This seems to be some Qt
magic. Before this patch, the raw pixel format number was also printed
with a space between the static text and the integer format.

> If that's all fine or resolved:
>
>
> Reviewed-by: Kieran Bingham <kieran.bingham at ideasonboard.com>
>
>
>>          } else {
>>                  qInfo() << "Zero-copy enabled";
>>          }
>> --
>> 2.34.1
>>