[libcamera-devel] [PATCH v1 2/2] ipa: raspberrypi: config: Increase the max gain in the exposure profiles

Kieran Bingham kieran.bingham at ideasonboard.com
Tue Feb 1 01:02:12 CET 2022


Quoting Naushir Patuck (2022-01-24 10:31:07)
> Increase the maximum allowable gain from 6.0 to 8.0 in the normal and short
> exposure profiles for all camera sensors. Increase this limit to 12.0 for the
> long exposure profiles for sensors where this has been defined.
> 
> The 6.0x value was somewhat arbitrarily chosen, and does limit the total
> exposure in dark conditions.
> 
> Signed-off-by: Naushir Patuck <naush at raspberrypi.com>

Reviewed-by: Kieran Bingham <kieran.bingham at ideasonboard.com>

> ---
>  src/ipa/raspberrypi/data/imx219.json      | 6 +++---
>  src/ipa/raspberrypi/data/imx219_noir.json | 6 +++---
>  src/ipa/raspberrypi/data/imx290.json      | 2 +-
>  src/ipa/raspberrypi/data/imx378.json      | 4 ++--
>  src/ipa/raspberrypi/data/imx477.json      | 6 +++---
>  src/ipa/raspberrypi/data/imx477_noir.json | 6 +++---
>  src/ipa/raspberrypi/data/imx519.json      | 4 ++--
>  src/ipa/raspberrypi/data/ov5647.json      | 6 +++---
>  src/ipa/raspberrypi/data/ov5647_noir.json | 6 +++---
>  src/ipa/raspberrypi/data/ov9281.json      | 2 +-
>  src/ipa/raspberrypi/data/se327m12.json    | 4 ++--
>  11 files changed, 26 insertions(+), 26 deletions(-)
> 
> diff --git a/src/ipa/raspberrypi/data/imx219.json b/src/ipa/raspberrypi/data/imx219.json
> index 1ec338be2ccb..de59d9363be4 100644
> --- a/src/ipa/raspberrypi/data/imx219.json
> +++ b/src/ipa/raspberrypi/data/imx219.json
> @@ -137,7 +137,7 @@
>                  ],
>                  "gain":
>                  [
> -                    1.0, 2.0, 4.0, 6.0, 6.0
> +                    1.0, 2.0, 4.0, 6.0, 8.0
>                  ]
>              },
>              "short":
> @@ -148,7 +148,7 @@
>                  ],
>                  "gain":
>                  [
> -                    1.0, 2.0, 4.0, 6.0, 6.0
> +                    1.0, 2.0, 4.0, 6.0, 8.0
>                  ]
>              },
>              "long":
> @@ -159,7 +159,7 @@
>                  ],
>                  "gain":
>                  [
> -                    1.0, 2.0, 4.0, 6.0, 6.0
> +                    1.0, 2.0, 4.0, 6.0, 12.0
>                  ]
>              }
>          },
> diff --git a/src/ipa/raspberrypi/data/imx219_noir.json b/src/ipa/raspberrypi/data/imx219_noir.json
> index 1d48ef53d33b..9a3f03ec86f4 100644
> --- a/src/ipa/raspberrypi/data/imx219_noir.json
> +++ b/src/ipa/raspberrypi/data/imx219_noir.json
> @@ -69,7 +69,7 @@
>                  ],
>                  "gain":
>                  [
> -                    1.0, 2.0, 4.0, 6.0, 6.0
> +                    1.0, 2.0, 4.0, 6.0, 8.0
>                  ]
>              },
>              "short":
> @@ -80,7 +80,7 @@
>                  ],
>                  "gain":
>                  [
> -                    1.0, 2.0, 4.0, 6.0, 6.0
> +                    1.0, 2.0, 4.0, 6.0, 8.0
>                  ]
>              },
>              "long":
> @@ -91,7 +91,7 @@
>                  ],
>                  "gain":
>                  [
> -                    1.0, 2.0, 4.0, 6.0, 6.0
> +                    1.0, 2.0, 4.0, 6.0, 12.0
>                  ]
>              }
>          },
> diff --git a/src/ipa/raspberrypi/data/imx290.json b/src/ipa/raspberrypi/data/imx290.json
> index 6fb92cc41593..20b45c1684c2 100644
> --- a/src/ipa/raspberrypi/data/imx290.json
> +++ b/src/ipa/raspberrypi/data/imx290.json
> @@ -79,7 +79,7 @@
>                  ],
>                  "gain":
>                  [
> -                    1.0, 2.0, 4.0, 6.0, 6.0
> +                    1.0, 2.0, 4.0, 6.0, 8.0
>                  ]
>              }
>          },
> diff --git a/src/ipa/raspberrypi/data/imx378.json b/src/ipa/raspberrypi/data/imx378.json
> index 3c2164e2ec63..6620034513f0 100644
> --- a/src/ipa/raspberrypi/data/imx378.json
> +++ b/src/ipa/raspberrypi/data/imx378.json
> @@ -134,7 +134,7 @@
>                  ],
>                  "gain":
>                  [
> -                    1.0, 2.0, 4.0, 6.0, 6.0
> +                    1.0, 2.0, 4.0, 6.0, 8.0
>                  ]
>              },
>              "short":
> @@ -145,7 +145,7 @@
>                  ],
>                  "gain":
>                  [
> -                    1.0, 2.0, 4.0, 6.0, 6.0
> +                    1.0, 2.0, 4.0, 6.0, 8.0
>                  ]
>              }
>          },
> diff --git a/src/ipa/raspberrypi/data/imx477.json b/src/ipa/raspberrypi/data/imx477.json
> index 9bee3f16e108..d07febd283ed 100644
> --- a/src/ipa/raspberrypi/data/imx477.json
> +++ b/src/ipa/raspberrypi/data/imx477.json
> @@ -137,7 +137,7 @@
>                  ],
>                  "gain":
>                  [
> -                    1.0, 2.0, 4.0, 6.0, 6.0
> +                    1.0, 2.0, 4.0, 6.0, 8.0
>                  ]
>              },
>              "short":
> @@ -148,7 +148,7 @@
>                  ],
>                  "gain":
>                  [
> -                    1.0, 2.0, 4.0, 6.0, 6.0
> +                    1.0, 2.0, 4.0, 6.0, 8.0
>                  ]
>              },
>              "long":
> @@ -159,7 +159,7 @@
>                  ],
>                  "gain":
>                  [
> -                    1.0, 2.0, 4.0, 6.0, 6.0
> +                    1.0, 2.0, 4.0, 6.0, 12.0
>                  ]
>              }
>          },
> diff --git a/src/ipa/raspberrypi/data/imx477_noir.json b/src/ipa/raspberrypi/data/imx477_noir.json
> index 290e8264bba9..7d4fc7dab9fd 100644
> --- a/src/ipa/raspberrypi/data/imx477_noir.json
> +++ b/src/ipa/raspberrypi/data/imx477_noir.json
> @@ -69,7 +69,7 @@
>                  ],
>                  "gain":
>                  [
> -                    1.0, 2.0, 4.0, 6.0, 6.0
> +                    1.0, 2.0, 4.0, 6.0, 8.0
>                  ]
>              },
>              "short":
> @@ -80,7 +80,7 @@
>                  ],
>                  "gain":
>                  [
> -                    1.0, 2.0, 4.0, 6.0, 6.0
> +                    1.0, 2.0, 4.0, 6.0, 8.0
>                  ]
>              },
>              "long":
> @@ -91,7 +91,7 @@
>                  ],
>                  "gain":
>                  [
> -                    1.0, 2.0, 4.0, 6.0, 6.0
> +                    1.0, 2.0, 4.0, 6.0, 12.0
>                  ]
>              }
>          },
> diff --git a/src/ipa/raspberrypi/data/imx519.json b/src/ipa/raspberrypi/data/imx519.json
> index 164d0d9d1b79..2ce6a08c029d 100644
> --- a/src/ipa/raspberrypi/data/imx519.json
> +++ b/src/ipa/raspberrypi/data/imx519.json
> @@ -134,7 +134,7 @@
>                  ],
>                  "gain":
>                  [
> -                    1.0, 2.0, 4.0, 6.0, 6.0
> +                    1.0, 2.0, 4.0, 6.0, 8.0
>                  ]
>              },
>              "short":
> @@ -145,7 +145,7 @@
>                  ],
>                  "gain":
>                  [
> -                    1.0, 2.0, 4.0, 6.0, 6.0
> +                    1.0, 2.0, 4.0, 6.0, 8.0
>                  ]
>              }
>          },
> diff --git a/src/ipa/raspberrypi/data/ov5647.json b/src/ipa/raspberrypi/data/ov5647.json
> index 1a354f7cb036..24bc06fb6114 100644
> --- a/src/ipa/raspberrypi/data/ov5647.json
> +++ b/src/ipa/raspberrypi/data/ov5647.json
> @@ -137,7 +137,7 @@
>                  ],
>                  "gain":
>                  [
> -                    1.0, 2.0, 4.0, 6.0, 6.0
> +                    1.0, 2.0, 4.0, 6.0, 8.0
>                  ]
>              },
>              "short":
> @@ -148,7 +148,7 @@
>                  ],
>                  "gain":
>                  [
> -                    1.0, 2.0, 4.0, 6.0, 6.0
> +                    1.0, 2.0, 4.0, 6.0, 8.0
>                  ]
>              },
>              "long":
> @@ -159,7 +159,7 @@
>                  ],
>                  "gain":
>                  [
> -                    1.0, 2.0, 4.0, 6.0, 6.0
> +                    1.0, 2.0, 4.0, 6.0, 12.0
>                  ]
>              }
>          },
> diff --git a/src/ipa/raspberrypi/data/ov5647_noir.json b/src/ipa/raspberrypi/data/ov5647_noir.json
> index c4bb21a0f34e..1c628ed13f19 100644
> --- a/src/ipa/raspberrypi/data/ov5647_noir.json
> +++ b/src/ipa/raspberrypi/data/ov5647_noir.json
> @@ -69,7 +69,7 @@
>                  ],
>                  "gain":
>                  [
> -                    1.0, 2.0, 4.0, 6.0, 6.0
> +                    1.0, 2.0, 4.0, 6.0, 8.0
>                  ]
>              },
>              "short":
> @@ -80,7 +80,7 @@
>                  ],
>                  "gain":
>                  [
> -                    1.0, 2.0, 4.0, 6.0, 6.0
> +                    1.0, 2.0, 4.0, 6.0, 8.0
>                  ]
>              },
>              "long":
> @@ -91,7 +91,7 @@
>                  ],
>                  "gain":
>                  [
> -                    1.0, 2.0, 4.0, 6.0, 6.0
> +                    1.0, 2.0, 4.0, 6.0, 12.0
>                  ]
>              }
>          },
> diff --git a/src/ipa/raspberrypi/data/ov9281.json b/src/ipa/raspberrypi/data/ov9281.json
> index ecd262be12ad..2319448b1593 100644
> --- a/src/ipa/raspberrypi/data/ov9281.json
> +++ b/src/ipa/raspberrypi/data/ov9281.json
> @@ -32,7 +32,7 @@
>              "normal":
>              {
>                  "shutter": [ 100, 15000, 30000, 60000, 120000 ],
> -                "gain":    [ 1.0, 2.0,   3.0,   4.0,   6.0    ]
> +                "gain":    [ 1.0, 2.0,   3.0,   4.0,   8.0    ]
>              }
>          },
>          "constraint_modes":
> diff --git a/src/ipa/raspberrypi/data/se327m12.json b/src/ipa/raspberrypi/data/se327m12.json
> index 3245ed98c1b1..94af2239f700 100644
> --- a/src/ipa/raspberrypi/data/se327m12.json
> +++ b/src/ipa/raspberrypi/data/se327m12.json
> @@ -134,7 +134,7 @@
>                  ],
>                  "gain":
>                  [
> -                    1.0, 2.0, 4.0, 6.0, 6.0
> +                    1.0, 2.0, 4.0, 6.0, 8.0
>                  ]
>              },
>              "short":
> @@ -145,7 +145,7 @@
>                  ],
>                  "gain":
>                  [
> -                    1.0, 2.0, 4.0, 6.0, 6.0
> +                    1.0, 2.0, 4.0, 6.0, 8.0
>                  ]
>              }
>          },
> -- 
> 2.25.1
>


More information about the libcamera-devel mailing list