[libcamera-devel] [PATCH 3/3] ipa: raspberrypi: Reduce the controller rate to 30fps

[David Plowman]

Hi Naush

Yes, I'm fine with this too.

On Mon, 7 Feb 2022 at 23:42, Laurent Pinchart
<laurent.pinchart at ideasonboard.com> wrote:
>
> Hi Naush,
>
> Thank you for the patch.
>
> On Mon, Feb 07, 2022 at 03:12:14PM +0000, Naushir Patuck wrote:
> > With the controller algorithms running at 60fps, there are some dropped frames
> > when running at very high famerates. Reducing this to 30fps eliminates all these
> > drops without any noticeable changes to the image quality.
> >
> > Signed-off-by: Naushir Patuck <naush at raspberrypi.com>
>
> This appears reasonable to me,
>
> Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>
>
> A review from David would be nice too.

Reviewed-by: David Plowman <david.plowman at raspberrypi.com>

Thanks!

David

>
> > ---
> >  src/ipa/raspberrypi/raspberrypi.cpp | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/src/ipa/raspberrypi/raspberrypi.cpp b/src/ipa/raspberrypi/raspberrypi.cpp
> > index a72d516f84ee..fd8fecb07f81 100644
> > --- a/src/ipa/raspberrypi/raspberrypi.cpp
> > +++ b/src/ipa/raspberrypi/raspberrypi.cpp
> > @@ -70,7 +70,7 @@ constexpr Duration defaultMaxFrameDuration = 250.0s;
> >   * we rate-limit the controller Prepare() and Process() calls to lower than or
> >   * equal to this rate.
> >   */
> > -constexpr Duration controllerMinFrameDuration = 1.0s / 60.0;
> > +constexpr Duration controllerMinFrameDuration = 1.0s / 30.0;
> >
> >  LOG_DEFINE_CATEGORY(IPARPI)
> >
>
> --
> Regards,
>
> Laurent Pinchart