[libcamera-devel] [PATCH v3 3/5] ipa: libipa: Histogram: Constify the constructor span

Jean-Michel Hautbois jeanmichel.hautbois at ideasonboard.com
Thu Feb 24 12:33:45 CET 2022


The Histogram constructor does not modify the data. Pass it a Span<const
uint32_t> instead of a Span<uint32_t>.

Signed-off-by: Jean-Michel Hautbois <jeanmichel.hautbois at ideasonboard.com>
---
 src/ipa/libipa/histogram.cpp | 2 +-
 src/ipa/libipa/histogram.h   | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/ipa/libipa/histogram.cpp b/src/ipa/libipa/histogram.cpp
index 4d94571f..d8ad1c89 100644
--- a/src/ipa/libipa/histogram.cpp
+++ b/src/ipa/libipa/histogram.cpp
@@ -32,7 +32,7 @@ namespace ipa {
  * \brief Create a cumulative histogram
  * \param[in] data A pre-sorted histogram to be passed
  */
-Histogram::Histogram(Span<uint32_t> data)
+Histogram::Histogram(Span<const uint32_t> data)
 {
 	cumulative_.reserve(data.size());
 	cumulative_.push_back(0);
diff --git a/src/ipa/libipa/histogram.h b/src/ipa/libipa/histogram.h
index c40a366b..164d4603 100644
--- a/src/ipa/libipa/histogram.h
+++ b/src/ipa/libipa/histogram.h
@@ -22,7 +22,7 @@ namespace ipa {
 class Histogram
 {
 public:
-	Histogram(Span<uint32_t> data);
+	Histogram(Span<const uint32_t> data);
 	size_t bins() const { return cumulative_.size() - 1; }
 	uint64_t total() const { return cumulative_[cumulative_.size() - 1]; }
 	uint64_t cumulativeFrequency(double bin) const;
-- 
2.32.0



More information about the libcamera-devel mailing list