[libcamera-devel] [PATCH] libcamera: pkg-config: Do not hardcode version

[Laurent Pinchart]

Hi Kieran,

Thank you for the patch.

On Tue, Jan 04, 2022 at 11:26:57PM +0000, Kieran Bingham wrote:
> The pkg-config version should not be hardcoded, and it should match the
> version of the library, ideally with point releases where possible.
> 
> Signed-off-by: Kieran Bingham <kieran.bingham at ideasonboard.com>

Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>

> ---
> 
> With this patch, the pkg-config libcamera.pc will report
>   Version: 0.0.0
> As defined by our meson project instead of 
>   Version: 1.0
> 
>  src/libcamera/base/meson.build | 1 -
>  src/libcamera/meson.build      | 1 -
>  2 files changed, 2 deletions(-)
> 
> diff --git a/src/libcamera/base/meson.build b/src/libcamera/base/meson.build
> index 0ae3b0aab7e2..7030ad1f5927 100644
> --- a/src/libcamera/base/meson.build
> +++ b/src/libcamera/base/meson.build
> @@ -65,7 +65,6 @@ libcamera_base = declare_dependency(sources : [
>  
>  pkg_mod = import('pkgconfig')
>  pkg_mod.generate(libcamera_base_lib,
> -                 version : '1.0',
>                   description : 'Camera support base utility library',
>                   subdirs : 'libcamera')
>  
> diff --git a/src/libcamera/meson.build b/src/libcamera/meson.build
> index 7ae909d47fe5..26912ca17819 100644
> --- a/src/libcamera/meson.build
> +++ b/src/libcamera/meson.build
> @@ -162,7 +162,6 @@ libcamera_private = declare_dependency(sources : [
>  pkg_mod = import('pkgconfig')
>  pkg_mod.generate(libcamera,
>                   libraries : libcamera_base_lib,
> -                 version : '1.0',
>                   description : 'Complex Camera Support Library',
>                   subdirs : 'libcamera')
>  

-- 
Regards,

Laurent Pinchart