[libcamera-devel] [PATCH v1] pipeline: raspberrypi: Demote the category of a logging message

[David Plowman]

Hi Naush

Thanks for the patch!

On Mon, 10 Jan 2022 at 10:23, Naushir Patuck <naush at raspberrypi.com> wrote:
>
> Switch the "no buffers available" log message from Info to Debug so that it does
> not get output by default.
>
> Signed-off-by: Naushir Patuck <naush at raspberrypi.com>
> ---
>  src/libcamera/pipeline/raspberrypi/rpi_stream.cpp | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/src/libcamera/pipeline/raspberrypi/rpi_stream.cpp b/src/libcamera/pipeline/raspberrypi/rpi_stream.cpp
> index bab80d25ad1a..a4159e20b068 100644
> --- a/src/libcamera/pipeline/raspberrypi/rpi_stream.cpp
> +++ b/src/libcamera/pipeline/raspberrypi/rpi_stream.cpp
> @@ -130,8 +130,8 @@ int Stream::queueBuffer(FrameBuffer *buffer)
>          */
>         if (!buffer) {
>                 if (availableBuffers_.empty()) {
> -                       LOG(RPISTREAM, Info) << "No buffers available for "
> -                                               << name_;
> +                       LOG(RPISTREAM, Debug) << "No buffers available for "
> +                                             << name_;

Yes, I agree this makes sense along with that other little fix that we
talked about (making the embedded data stream non-external).

Reviewed-by: David Plowman <david.plowman at raspberrypi.com>

Thanks!
David

>                         /*
>                          * Note that we need to queue an internal buffer as soon
>                          * as one becomes available.
> --
> 2.25.1
>