[libcamera-devel] [PATCH v1 3/5] v4l2: v4l2_camera_proxy: Drop trace message from freeBuffers()

Kieran Bingham kieran.bingham at ideasonboard.com
Mon Jan 10 17:41:50 CET 2022


Quoting Laurent Pinchart (2021-12-28 21:59:49)
> The freeBuffers() function is only called from vidioc_reqbufs(), which
> already logs a trace message. Remove the duplicate.
> 
> Signed-off-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>

Reviewed-by: Kieran Bingham <kieran.bingham at ideasonboard.com>

> ---
>  src/v4l2/v4l2_camera_proxy.cpp | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/src/v4l2/v4l2_camera_proxy.cpp b/src/v4l2/v4l2_camera_proxy.cpp
> index c1375777c185..80e6624bc9b7 100644
> --- a/src/v4l2/v4l2_camera_proxy.cpp
> +++ b/src/v4l2/v4l2_camera_proxy.cpp
> @@ -445,8 +445,6 @@ int V4L2CameraProxy::vidioc_s_input(V4L2CameraFile *file, int *arg)
>  
>  void V4L2CameraProxy::freeBuffers()
>  {
> -       LOG(V4L2Compat, Debug) << "Freeing libcamera bufs";
> -
>         vcam_->freeBuffers();
>         buffers_.clear();
>         bufferCount_ = 0;
> -- 
> Regards,
> 
> Laurent Pinchart
>


More information about the libcamera-devel mailing list