[libcamera-devel] [PATCH 5/5] android: camera_device: Print the correct number of completed streams

[Hirokazu Honda]

Hi Jacopo, thank you for the patch.

On Tue, Jan 11, 2022 at 1:54 AM Jacopo Mondi <jacopo at jmondi.org> wrote:
>
> When a request completes, a debug message is generated to help
> identify the request and the number of streams if contains.
>
> The printed number of streams is however the number of output buffers
> requested by the camera framework, not the number of streams generated
> by libcamera. In facts, some output buffers are generated by
> post-processing, and not directly from the camera.
>
> As the debug message prints the libcamera identifier for the Request, it
> is more logical to print the number of streams generated by the camera
> instead of the total number of streams.
>
> Signed-off-by: Jacopo Mondi <jacopo at jmondi.org>

Reviewed-by: Hirokazu Honda <hiroh at chromium.org>

> ---
>  src/android/camera_device.cpp | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp
> index 4e44bcfa0852..88cb4f943757 100644
> --- a/src/android/camera_device.cpp
> +++ b/src/android/camera_device.cpp
> @@ -1196,7 +1196,7 @@ void CameraDevice::requestComplete(Request *request)
>         notifyShutter(descriptor->frameNumber_, sensorTimestamp);
>
>         LOG(HAL, Debug) << "Request " << request->cookie() << " completed with "
> -                       << descriptor->buffers_.size() << " streams";
> +                       << descriptor->request_->buffers().size() << " streams";
>
>         /*
>          * Generate the metadata associated with the captured buffers.
> --
> 2.34.1
>