[libcamera-devel] [PATCH 1/3] qcam: viewfinder_qt: Fix include orders

Laurent Pinchart laurent.pinchart at ideasonboard.com
Tue Jul 5 22:56:39 CEST 2022


Hi Kieran,

Thank you for the patch.

On Tue, Jul 05, 2022 at 04:31:09PM +0100, Kieran Bingham via libcamera-devel wrote:
> Update the header orders to match the code style as decreed by
> clang-format.
> 
> Signed-off-by: Kieran Bingham <kieran.bingham at ideasonboard.com>

Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>

> ---
>  src/qcam/viewfinder_qt.cpp | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/src/qcam/viewfinder_qt.cpp b/src/qcam/viewfinder_qt.cpp
> index 6844f998bbe0..27955e3f9593 100644
> --- a/src/qcam/viewfinder_qt.cpp
> +++ b/src/qcam/viewfinder_qt.cpp
> @@ -11,6 +11,8 @@
>  #include <stdint.h>
>  #include <utility>
>  
> +#include <libcamera/formats.h>
> +
>  #include <QImage>
>  #include <QImageWriter>
>  #include <QMap>
> @@ -18,9 +20,8 @@
>  #include <QPainter>
>  #include <QtDebug>
>  
> -#include <libcamera/formats.h>
> -
>  #include "../cam/image.h"
> +
>  #include "format_converter.h"
>  
>  static const QMap<libcamera::PixelFormat, QImage::Format> nativeFormats

-- 
Regards,

Laurent Pinchart


More information about the libcamera-devel mailing list