[libcamera-devel] [PATCH 2/3] qcam: format_converter: Support X RGB variants

[Laurent Pinchart]

Hi Kieran,

Thank you for the patch.

On Tue, Jul 05, 2022 at 04:31:10PM +0100, Kieran Bingham via libcamera-devel wrote:
> Support the X variants of the RGB pixel formats
> along side the equivalent Alpha component based versions.
> 
> Signed-off-by: Kieran Bingham <kieran.bingham at ideasonboard.com>

Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>

> ---
>  src/qcam/format_converter.cpp | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/src/qcam/format_converter.cpp b/src/qcam/format_converter.cpp
> index d4d3223bc698..9331da0ce7a3 100644
> --- a/src/qcam/format_converter.cpp
> +++ b/src/qcam/format_converter.cpp
> @@ -93,6 +93,7 @@ int FormatConverter::configure(const libcamera::PixelFormat &format,
>  		bpp_ = 3;
>  		break;
>  	case libcamera::formats::ARGB8888:
> +	case libcamera::formats::XRGB8888:
>  		formatFamily_ = RGB;
>  		r_pos_ = 2;
>  		g_pos_ = 1;
> @@ -100,6 +101,7 @@ int FormatConverter::configure(const libcamera::PixelFormat &format,
>  		bpp_ = 4;
>  		break;
>  	case libcamera::formats::RGBA8888:
> +	case libcamera::formats::RGBX8888:
>  		formatFamily_ = RGB;
>  		r_pos_ = 3;
>  		g_pos_ = 2;
> @@ -107,6 +109,7 @@ int FormatConverter::configure(const libcamera::PixelFormat &format,
>  		bpp_ = 4;
>  		break;
>  	case libcamera::formats::ABGR8888:
> +	case libcamera::formats::XBGR8888:
>  		formatFamily_ = RGB;
>  		r_pos_ = 0;
>  		g_pos_ = 1;
> @@ -114,6 +117,7 @@ int FormatConverter::configure(const libcamera::PixelFormat &format,
>  		bpp_ = 4;
>  		break;
>  	case libcamera::formats::BGRA8888:
> +	case libcamera::formats::BGRX8888:
>  		formatFamily_ = RGB;
>  		r_pos_ = 1;
>  		g_pos_ = 2;

-- 
Regards,

Laurent Pinchart