[libcamera-devel] [PATCH] meson: correctly pass the global include to the compiler

Kieran Bingham kieran.bingham at ideasonboard.com
Wed Jul 6 21:28:47 CEST 2022


Hi Eli,

Quoting Eli Schwartz via libcamera-devel (2022-07-06 20:10:16)
> It's not safe to assume `-include config.h` works, since this depends on
> the functionality of the compiler that the cwd when running the compiler
> is searched first.
> 
> When libcamera is included as a Meson subproject, the cwd of the
> compiler is the cwd of the main project, not of libcamera's build dir,
> and thus cannot be found. Instead, pass the include filename as a path
> based on the current build dir.
> 

Thank you for identifying this so quickly and supporting on the meson
channel.

Reviewed-by: Kieran Bingham <kieran.bingham at ideasonboard.com>

> Signed-off-by: Eli Schwartz <eschwartz93 at gmail.com>
> ---
>  meson.build | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/meson.build b/meson.build
> index 6d7d3ca6..3f7a3f56 100644
> --- a/meson.build
> +++ b/meson.build
> @@ -44,7 +44,7 @@ endif
>  
>  common_arguments = [
>      '-Wshadow',
> -    '-include', 'config.h',
> +    '-include', meson.current_build_dir() / 'config.h',
>  ]
>  
>  c_arguments = []
> -- 
> 2.35.1
>


More information about the libcamera-devel mailing list