[libcamera-devel] Video recording on PinePhone Re: libcamera on pinephone

[Nicolas Dufresne]

Le mardi 05 juillet 2022 à 23:39 +0300, Rafael Diniz a écrit :
> and indeed, reading stuff like this (in gstlibcamera-utils.cpp):
> 
> 	} else if (gst_structure_has_name(s, "image/jpeg")) {
> 		stream_cfg.pixelFormat = formats::MJPEG;
> 	} else {
> 
> makes me think twice if adding "JPEG" near "MJPEG" everywhere is a good 
> idea. Many hardcoded stuff which needs to be fixed I think.

I could not really understand this part of your comment. Though what your
backtrace expose is that:


void
gst_libcamera_configure_stream_from_caps(StreamConfiguration &stream_cfg,
					 GstCaps *caps)
{
	GstVideoFormat gst_format = pixel_format_to_gst_format(stream_cfg.pixelFormat);

gst_format is GST_VIDEO_FORMAT_UNKNOWN, probably because stream_cfg.pixelFormat
is missing in the format_map[]. The return value should have been handled
cleanly here, and skipped.

regards,
Nicolas