[libcamera-devel] [PATCH 2/4] ipa: rkisp1: Transfer queueRequest() call to each algorithm

[Laurent Pinchart]

Hi Florian,

Thank you for the patch.

On Mon, Jul 04, 2022 at 05:23:16PM +0200, Florian Sylvestre via libcamera-devel wrote:
> Implement rkisp1 queueRequest() function to update each algorithm with user
> controls.
> 
> Signed-off-by: Florian Sylvestre <fsylvestre at baylibre.com>
> ---
>  src/ipa/rkisp1/rkisp1.cpp | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/src/ipa/rkisp1/rkisp1.cpp b/src/ipa/rkisp1/rkisp1.cpp
> index a32bb9d1..9b0d675c 100644
> --- a/src/ipa/rkisp1/rkisp1.cpp
> +++ b/src/ipa/rkisp1/rkisp1.cpp
> @@ -270,9 +270,10 @@ void IPARkISP1::unmapBuffers(const std::vector<unsigned int> &ids)
>  }
>  
>  void IPARkISP1::queueRequest([[maybe_unused]] const uint32_t frame,

You can drop this [[maybe_unused]] too.

Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>

> -			     [[maybe_unused]] const ControlList &controls)
> +			     const ControlList &controls)
>  {
> -	/* \todo Start processing for 'frame' based on 'controls'. */
> +	for (auto const &algo : algorithms())
> +		algo->queueRequest(context_, frame, controls);
>  }
>  
>  void IPARkISP1::fillParamsBuffer(const uint32_t frame, const uint32_t bufferId)

-- 
Regards,

Laurent Pinchart