[libcamera-devel] [PATCH v4 0/8] Replace boost JSON parser with libyaml in Raspberry Pi IPA

Naushir Patuck naush at raspberrypi.com
Wed Jul 13 11:21:51 CEST 2022


Hi,

This is a continuation of the series started by Laurent on replacing the boost
JSON parser with libyaml. I've removed the RFC tag from this series, and tagged
Laurent's patches 1/8 - 3/8. I have a few minor comments on 4/8 that I will
reply to separately.

This version adds the following patches for the Raspberry Pi IPA and CTT:

5/8 - Add support for new format of the tuning file that explicitly sets algorithm ordering.
6/8 - Add a python script that converts our existing JSON format to the new one.
7/8 - Updates the CTT to output the new format tuning files.
8/8 - Updates our existing tuning files to the new format with the script.

Regards,
Naush

Laurent Pinchart (4):
  test: yaml-parser: Test dictionary items ordering
  libcamera: yaml_parser: Preserve order of items in dictionary
  ipa: raspberrypi: Replace tabs with spaces in tuning data files
  ipa: raspberrypi: Use YamlParser to replace dependency on boost

Naushir Patuck (4):
  ipa: raspberrypi: Introduce version 2.0 format for the camera tuning
    file
  utils: raspberrypi: Add tuning file conversion script
  utils: raspberrypi: ctt: Output version 2.0 format tuning files
  ipa: raspberrypi: Convert existing cameara tuning files to version 2.0

 README.rst                                    |   6 -
 include/libcamera/internal/yaml_parser.h      |  37 +-
 src/ipa/raspberrypi/controller/algorithm.cpp  |   2 +-
 src/ipa/raspberrypi/controller/algorithm.hpp  |   6 +-
 src/ipa/raspberrypi/controller/controller.cpp |  59 +-
 src/ipa/raspberrypi/controller/controller.hpp |   4 +-
 src/ipa/raspberrypi/controller/pwl.cpp        |  12 +-
 src/ipa/raspberrypi/controller/pwl.hpp        |   5 +-
 src/ipa/raspberrypi/controller/rpi/agc.cpp    |  94 +-
 src/ipa/raspberrypi/controller/rpi/agc.hpp    |  10 +-
 src/ipa/raspberrypi/controller/rpi/alsc.cpp   |  94 +-
 src/ipa/raspberrypi/controller/rpi/alsc.hpp   |   2 +-
 src/ipa/raspberrypi/controller/rpi/awb.cpp    |  89 +-
 src/ipa/raspberrypi/controller/rpi/awb.hpp    |   8 +-
 .../controller/rpi/black_level.cpp            |  12 +-
 .../controller/rpi/black_level.hpp            |   2 +-
 src/ipa/raspberrypi/controller/rpi/ccm.cpp    |  28 +-
 src/ipa/raspberrypi/controller/rpi/ccm.hpp    |   4 +-
 .../raspberrypi/controller/rpi/contrast.cpp   |  18 +-
 .../raspberrypi/controller/rpi/contrast.hpp   |   2 +-
 src/ipa/raspberrypi/controller/rpi/dpc.cpp    |   4 +-
 src/ipa/raspberrypi/controller/rpi/dpc.hpp    |   2 +-
 src/ipa/raspberrypi/controller/rpi/geq.cpp    |  10 +-
 src/ipa/raspberrypi/controller/rpi/geq.hpp    |   2 +-
 src/ipa/raspberrypi/controller/rpi/lux.cpp    |  12 +-
 src/ipa/raspberrypi/controller/rpi/lux.hpp    |   2 +-
 src/ipa/raspberrypi/controller/rpi/noise.cpp  |   6 +-
 src/ipa/raspberrypi/controller/rpi/noise.hpp  |   2 +-
 src/ipa/raspberrypi/controller/rpi/sdn.cpp    |   6 +-
 src/ipa/raspberrypi/controller/rpi/sdn.hpp    |   2 +-
 .../raspberrypi/controller/rpi/sharpen.cpp    |   8 +-
 .../raspberrypi/controller/rpi/sharpen.hpp    |   2 +-
 src/ipa/raspberrypi/data/imx219.json          | 760 ++++++++--------
 src/ipa/raspberrypi/data/imx219_noir.json     | 647 +++++++-------
 src/ipa/raspberrypi/data/imx290.json          | 300 +++----
 src/ipa/raspberrypi/data/imx296.json          | 338 ++++----
 src/ipa/raspberrypi/data/imx378.json          | 617 ++++++-------
 src/ipa/raspberrypi/data/imx477.json          | 808 +++++++++---------
 src/ipa/raspberrypi/data/imx477_noir.json     | 688 ++++++++-------
 src/ipa/raspberrypi/data/imx519.json          | 617 ++++++-------
 src/ipa/raspberrypi/data/ov5647.json          | 758 ++++++++--------
 src/ipa/raspberrypi/data/ov5647_noir.json     | 645 +++++++-------
 src/ipa/raspberrypi/data/ov9281.json          | 160 ++--
 src/ipa/raspberrypi/data/se327m12.json        | 622 +++++++-------
 src/ipa/raspberrypi/data/uncalibrated.json    | 137 ++-
 src/ipa/raspberrypi/meson.build               |   1 -
 src/ipa/raspberrypi/raspberrypi.cpp           |   1 +
 src/libcamera/yaml_parser.cpp                 |  35 +-
 test/yaml-parser.cpp                          |  17 +-
 utils/raspberrypi/ctt/convert_tuning.py       |  94 ++
 utils/raspberrypi/ctt/ctt.py                  |  13 +-
 51 files changed, 4066 insertions(+), 3744 deletions(-)
 create mode 100755 utils/raspberrypi/ctt/convert_tuning.py

-- 
2.25.1



More information about the libcamera-devel mailing list