[libcamera-devel] [PATCH v1.1] gstreamer: Be pedantic on srcpads access

[Laurent Pinchart]

On Fri, Jul 15, 2022 at 12:35:36PM +0100, Kieran Bingham via libcamera-devel wrote:
> Quoting Umang Jain via libcamera-devel (2022-06-30 07:34:43)
> > Use the std::vector::back() instead of [0] index which corresponds
> > to std::vector::push_back() for tracking of pads. This doesn't
> > introduce a functional change as the gst_libcamera_src_init() will
> > only add one pad but it helps with readability.
> > 
> > Signed-off-by: Umang Jain <umang.jain at ideasonboard.com>
> 
> Reviewed-by: Kieran Bingham <kieran.bingham at ideasonboard.com>

Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>

> > ---
> >  src/gstreamer/gstlibcamerasrc.cpp | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/src/gstreamer/gstlibcamerasrc.cpp b/src/gstreamer/gstlibcamerasrc.cpp
> > index 46fd02d2..4813ab96 100644
> > --- a/src/gstreamer/gstlibcamerasrc.cpp
> > +++ b/src/gstreamer/gstlibcamerasrc.cpp
> > @@ -631,7 +631,7 @@ gst_libcamera_src_init(GstLibcameraSrc *self)
> >         gst_task_set_lock(self->task, &self->stream_lock);
> >  
> >         state->srcpads_.push_back(gst_pad_new_from_template(templ, "src"));
> > -       gst_element_add_pad(GST_ELEMENT(self), state->srcpads_[0]);
> > +       gst_element_add_pad(GST_ELEMENT(self), state->srcpads_.back());
> >  
> >         /* C-style friend. */
> >         state->src_ = self;

-- 
Regards,

Laurent Pinchart