[libcamera-devel] [PATCH] libcamera: pipeline: simple: converter: Handle unsupported input format

Xavier Roumegue xavier.roumegue at oss.nxp.com
Fri Jul 15 17:16:07 CEST 2022


SimpleConverter::formats() should return an empty vector if the input
format is not supported by the converter.

Signed-off-by: Xavier Roumegue <xavier.roumegue at oss.nxp.com>
---
 src/libcamera/pipeline/simple/converter.cpp | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/src/libcamera/pipeline/simple/converter.cpp b/src/libcamera/pipeline/simple/converter.cpp
index 77c44fc8..19134edc 100644
--- a/src/libcamera/pipeline/simple/converter.cpp
+++ b/src/libcamera/pipeline/simple/converter.cpp
@@ -220,6 +220,12 @@ std::vector<PixelFormat> SimpleConverter::formats(PixelFormat input)
 		return {};
 	}
 
+	if (v4l2Format.fourcc != V4L2PixelFormat::fromPixelFormat(input)) {
+		LOG(SimplePipeline, Debug)
+			<< "Input format " << input.toString() << " not supported.";
+		return {};
+	}
+
 	std::vector<PixelFormat> pixelFormats;
 
 	for (const auto &format : m2m_->capture()->formats()) {
-- 
2.36.1



More information about the libcamera-devel mailing list