[libcamera-devel] [PATCH v2 2/4] ipa: rkisp1: Transfer queueRequest() call to each algorithm

[paul.elder at ideasonboard.com]

Hi Florian,

On Wed, Jul 20, 2022 at 05:42:19PM +0200, Florian Sylvestre via libcamera-devel wrote:
> Implement rkisp1 queueRequest() function to update each algorithm with user
> controls.
> 
> Signed-off-by: Florian Sylvestre <fsylvestre at baylibre.com>
> Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>

Reviewed-by: Paul Elder <paul.elder at ideasonboard.com>

> ---
>  src/ipa/rkisp1/rkisp1.cpp | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/src/ipa/rkisp1/rkisp1.cpp b/src/ipa/rkisp1/rkisp1.cpp
> index a32bb9d1..34034526 100644
> --- a/src/ipa/rkisp1/rkisp1.cpp
> +++ b/src/ipa/rkisp1/rkisp1.cpp
> @@ -269,10 +269,10 @@ void IPARkISP1::unmapBuffers(const std::vector<unsigned int> &ids)
>  	}
>  }
>  
> -void IPARkISP1::queueRequest([[maybe_unused]] const uint32_t frame,
> -			     [[maybe_unused]] const ControlList &controls)
> +void IPARkISP1::queueRequest(const uint32_t frame, const ControlList &controls)
>  {
> -	/* \todo Start processing for 'frame' based on 'controls'. */
> +	for (auto const &algo : algorithms())
> +		algo->queueRequest(context_, frame, controls);
>  }
>  
>  void IPARkISP1::fillParamsBuffer(const uint32_t frame, const uint32_t bufferId)
> -- 
> 2.34.1
>