[libcamera-devel] [PATCH 1/2] test: gstreamer: Drop internal header from base class

Umang Jain umang.jain at ideasonboard.com
Thu Jul 21 15:45:30 CEST 2022


The internal header isn't needed. The needed function
libcameraBuildPath() is exposed by libcamera/base/utils.h header.
At the same time, move the utils header to .cpp instead of including
it in the base class header itself.

Signed-off-by: Umang Jain <umang.jain at ideasonboard.com>
---
 test/gstreamer/gstreamer_test.cpp | 2 ++
 test/gstreamer/gstreamer_test.h   | 4 ----
 2 files changed, 2 insertions(+), 4 deletions(-)

diff --git a/test/gstreamer/gstreamer_test.cpp b/test/gstreamer/gstreamer_test.cpp
index 227a5c37..cfb8afc6 100644
--- a/test/gstreamer/gstreamer_test.cpp
+++ b/test/gstreamer/gstreamer_test.cpp
@@ -5,6 +5,8 @@
  * libcamera Gstreamer element API tests
  */
 
+#include <libcamera/base/utils.h>
+
 #include "gstreamer_test.h"
 
 #include "test.h"
diff --git a/test/gstreamer/gstreamer_test.h b/test/gstreamer/gstreamer_test.h
index 9869d252..35adab0e 100644
--- a/test/gstreamer/gstreamer_test.h
+++ b/test/gstreamer/gstreamer_test.h
@@ -10,10 +10,6 @@
 #include <iostream>
 #include <unistd.h>
 
-#include <libcamera/base/utils.h>
-
-#include "libcamera/internal/source_paths.h"
-
 #include <gst/gst.h>
 
 class GstreamerTest
-- 
2.31.1



More information about the libcamera-devel mailing list