[libcamera-devel] [PATCH v6 4/8] ipa: raspberrypi: Use YamlParser to replace dependency on boost

Laurent Pinchart laurent.pinchart at ideasonboard.com
Fri Jul 22 21:25:37 CEST 2022


Hi Naush,

On Mon, Jul 18, 2022 at 09:15:58AM +0100, Naushir Patuck wrote:
> From: Laurent Pinchart <laurent.pinchart at ideasonboard.com>
> 
> The Raspberry Pi IPA module depends on boost only to parse the JSON
> tuning data files. As libcamera depends on libyaml, use the YamlParser
> class to parse those files and drop the dependency on boost.
> 
> Signed-off-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>

I assume you're fine with this patch as you've posted it as part of your
series, but could you give it a review ? :-)

> ---
>  README.rst                                    |  6 --
>  src/ipa/raspberrypi/controller/algorithm.cpp  |  2 +-
>  src/ipa/raspberrypi/controller/algorithm.hpp  |  6 +-
>  src/ipa/raspberrypi/controller/controller.cpp | 27 ++++--
>  src/ipa/raspberrypi/controller/pwl.cpp        | 12 ++-
>  src/ipa/raspberrypi/controller/pwl.hpp        |  5 +-
>  src/ipa/raspberrypi/controller/rpi/agc.cpp    | 94 +++++++++----------
>  src/ipa/raspberrypi/controller/rpi/agc.hpp    | 10 +-
>  src/ipa/raspberrypi/controller/rpi/alsc.cpp   | 94 +++++++++----------
>  src/ipa/raspberrypi/controller/rpi/alsc.hpp   |  2 +-
>  src/ipa/raspberrypi/controller/rpi/awb.cpp    | 89 +++++++++---------
>  src/ipa/raspberrypi/controller/rpi/awb.hpp    |  8 +-
>  .../controller/rpi/black_level.cpp            | 12 +--
>  .../controller/rpi/black_level.hpp            |  2 +-
>  src/ipa/raspberrypi/controller/rpi/ccm.cpp    | 28 +++---
>  src/ipa/raspberrypi/controller/rpi/ccm.hpp    |  4 +-
>  .../raspberrypi/controller/rpi/contrast.cpp   | 18 ++--
>  .../raspberrypi/controller/rpi/contrast.hpp   |  2 +-
>  src/ipa/raspberrypi/controller/rpi/dpc.cpp    |  4 +-
>  src/ipa/raspberrypi/controller/rpi/dpc.hpp    |  2 +-
>  src/ipa/raspberrypi/controller/rpi/geq.cpp    | 10 +-
>  src/ipa/raspberrypi/controller/rpi/geq.hpp    |  2 +-
>  src/ipa/raspberrypi/controller/rpi/lux.cpp    | 12 +--
>  src/ipa/raspberrypi/controller/rpi/lux.hpp    |  2 +-
>  src/ipa/raspberrypi/controller/rpi/noise.cpp  |  6 +-
>  src/ipa/raspberrypi/controller/rpi/noise.hpp  |  2 +-
>  src/ipa/raspberrypi/controller/rpi/sdn.cpp    |  6 +-
>  src/ipa/raspberrypi/controller/rpi/sdn.hpp    |  2 +-
>  .../raspberrypi/controller/rpi/sharpen.cpp    |  8 +-
>  .../raspberrypi/controller/rpi/sharpen.hpp    |  2 +-
>  src/ipa/raspberrypi/meson.build               |  1 -
>  src/ipa/raspberrypi/raspberrypi.cpp           |  1 +
>  32 files changed, 241 insertions(+), 240 deletions(-)

-- 
Regards,

Laurent Pinchart


More information about the libcamera-devel mailing list