[libcamera-devel] [RFC PATCH 12/12] ipa: ipu3: Transfer queueRequest() call to each algorithm

[Umang Jain]

Hi Kieran,

On 7/21/22 17:43, Kieran Bingham via libcamera-devel wrote:
> Implement the IPU3 queueRequest() function to allow each algorithm
> to process the user controls that it supports.
>
> Signed-off-by: Kieran Bingham <kieran.bingham at ideasonboard.com>


Looks good,

Can you summarize follow up to this patch? I believe each algorithm 
which take up ownership of the associated controls it manages ? That bit 
shall follow, right?

> ---
>   src/ipa/ipu3/ipu3.cpp | 6 ++----
>   1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/src/ipa/ipu3/ipu3.cpp b/src/ipa/ipu3/ipu3.cpp
> index 4d7a54f8d1a5..ee28044fc40e 100644
> --- a/src/ipa/ipu3/ipu3.cpp
> +++ b/src/ipa/ipu3/ipu3.cpp
> @@ -620,12 +620,10 @@ void IPAIPU3::processStatsBuffer(const uint32_t frame,
>    */
>   void IPAIPU3::queueRequest(const uint32_t frame, const ControlList &controls)
>   {
> -	/* \todo Start processing for 'frame' based on 'controls'. */
>   	IPU3FrameContext &frameContext = context_.frameContexts.initialise(frame);
>   
> -	/* \todo Implement queueRequest to each algorithm. */
> -	(void)frameContext;
> -	(void)controls;
> +	for (auto const &algo : algorithms_)
> +		algo->queueRequest(context_, frame, frameContext, controls);
>   }
>   
>   /**