[libcamera-devel] [PATCH 02/15] DNI: ipa: raspberrypi: Code refactoring to match style guidelines

Laurent Pinchart laurent.pinchart at ideasonboard.com
Mon Jul 25 21:47:33 CEST 2022


Hi Naush,

Thank you for the patch.

On Mon, Jul 25, 2022 at 02:46:26PM +0100, Naushir Patuck via libcamera-devel wrote:
> Refactor the source files src/ipa/raspberrypi/cam_helper* to match the
> recommended formatting guidelines for the libcamera project. The vast majority
> of changes in this commit comprise of switching from snake_case to CamelCase,
> and starting class member functions with a lower case character.
> 
> Signed-off-by: Naushir Patuck <naush at raspberrypi.com>

Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>

> ---
>  src/ipa/raspberrypi/cam_helper.cpp        | 88 +++++++++++------------
>  src/ipa/raspberrypi/cam_helper.hpp        | 40 +++++------
>  src/ipa/raspberrypi/cam_helper_imx219.cpp | 34 ++++-----
>  src/ipa/raspberrypi/cam_helper_imx290.cpp | 32 ++++-----
>  src/ipa/raspberrypi/cam_helper_imx296.cpp | 24 +++----
>  src/ipa/raspberrypi/cam_helper_imx477.cpp | 72 +++++++++----------
>  src/ipa/raspberrypi/cam_helper_imx519.cpp | 70 +++++++++---------
>  src/ipa/raspberrypi/cam_helper_ov5647.cpp | 44 ++++++------
>  src/ipa/raspberrypi/cam_helper_ov9281.cpp | 28 ++++----
>  9 files changed, 216 insertions(+), 216 deletions(-)

-- 
Regards,

Laurent Pinchart


More information about the libcamera-devel mailing list