[libcamera-devel] [PATCH 04/15] DNI: ipa: raspberrypi: Code refactoring to match style guidelines

Laurent Pinchart laurent.pinchart at ideasonboard.com
Mon Jul 25 21:54:09 CEST 2022


Hi Naush,

Thank you for the patch.

On Mon, Jul 25, 2022 at 02:46:28PM +0100, Naushir Patuck via libcamera-devel wrote:
> Refactor the source files under src/ipa/raspberrypi/controller/c* to match the
> recommended formatting guidelines for the libcamera project. The vast majority
> of changes in this commit comprise of switching from snake_case to CamelCase,
> and starting class member functions with a lower case character.
> 
> Signed-off-by: Naushir Patuck <naush at raspberrypi.com>

Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>

> ---
>  src/ipa/raspberrypi/controller/camera_mode.h  | 16 ++--
>  .../raspberrypi/controller/ccm_algorithm.hpp  |  2 +-
>  .../controller/contrast_algorithm.hpp         |  4 +-
>  src/ipa/raspberrypi/controller/controller.cpp | 74 ++++++++++---------
>  src/ipa/raspberrypi/controller/controller.hpp | 22 +++---
>  5 files changed, 60 insertions(+), 58 deletions(-)

-- 
Regards,

Laurent Pinchart


More information about the libcamera-devel mailing list