[libcamera-devel] [PATCH 13/15] ipa: raspberrypi: Rename header files from *.hpp to *.h

Laurent Pinchart laurent.pinchart at ideasonboard.com
Mon Jul 25 23:03:05 CEST 2022


Hi Naush,

Thank you for the patch.

On Mon, Jul 25, 2022 at 02:46:37PM +0100, Naushir Patuck via libcamera-devel wrote:
> As per the libcamera coding guidelines, rename all .hpp header files to .h.
> 
> Signed-off-by: Naushir Patuck <naush at raspberrypi.com>

Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>

> ---
>  src/ipa/raspberrypi/cam_helper.cpp             |  4 ++--
>  .../{cam_helper.hpp => cam_helper.h}           |  8 ++++----
>  src/ipa/raspberrypi/cam_helper_imx219.cpp      |  4 ++--
>  src/ipa/raspberrypi/cam_helper_imx290.cpp      |  2 +-
>  src/ipa/raspberrypi/cam_helper_imx296.cpp      |  2 +-
>  src/ipa/raspberrypi/cam_helper_imx477.cpp      |  4 ++--
>  src/ipa/raspberrypi/cam_helper_imx519.cpp      |  4 ++--
>  src/ipa/raspberrypi/cam_helper_ov5647.cpp      |  2 +-
>  src/ipa/raspberrypi/cam_helper_ov9281.cpp      |  2 +-
>  .../{agc_algorithm.hpp => agc_algorithm.h}     |  4 ++--
>  src/ipa/raspberrypi/controller/algorithm.cpp   |  2 +-
>  .../controller/{algorithm.hpp => algorithm.h}  |  4 ++--
>  .../{awb_algorithm.hpp => awb_algorithm.h}     |  4 ++--
>  .../{ccm_algorithm.hpp => ccm_algorithm.h}     |  4 ++--
>  ...rast_algorithm.hpp => contrast_algorithm.h} |  4 ++--
>  src/ipa/raspberrypi/controller/controller.cpp  |  4 ++--
>  .../{controller.hpp => controller.h}           |  4 ++--
>  ...noise_algorithm.hpp => denoise_algorithm.h} |  4 ++--
>  src/ipa/raspberrypi/controller/histogram.cpp   |  2 +-
>  .../controller/{histogram.hpp => histogram.h}  |  2 +-
>  .../controller/{metadata.hpp => metadata.h}    |  2 +-
>  src/ipa/raspberrypi/controller/pwl.cpp         |  2 +-
>  .../raspberrypi/controller/{pwl.hpp => pwl.h}  |  2 +-
>  src/ipa/raspberrypi/controller/rpi/agc.cpp     |  6 +++---
>  .../controller/rpi/{agc.hpp => agc.h}          |  6 +++---
>  src/ipa/raspberrypi/controller/rpi/alsc.cpp    |  2 +-
>  .../controller/rpi/{alsc.hpp => alsc.h}        |  4 ++--
>  src/ipa/raspberrypi/controller/rpi/awb.cpp     |  2 +-
>  .../controller/rpi/{awb.hpp => awb.h}          |  6 +++---
>  .../raspberrypi/controller/rpi/black_level.cpp |  2 +-
>  .../rpi/{black_level.hpp => black_level.h}     |  4 ++--
>  src/ipa/raspberrypi/controller/rpi/ccm.cpp     |  4 ++--
>  .../controller/rpi/{ccm.hpp => ccm.h}          |  6 +++---
>  .../raspberrypi/controller/rpi/contrast.cpp    |  4 ++--
>  .../rpi/{contrast.hpp => contrast.h}           |  6 +++---
>  src/ipa/raspberrypi/controller/rpi/dpc.cpp     |  2 +-
>  .../controller/rpi/{dpc.hpp => dpc.h}          |  4 ++--
>  src/ipa/raspberrypi/controller/rpi/focus.cpp   |  2 +-
>  .../controller/rpi/{focus.hpp => focus.h}      |  6 +++---
>  src/ipa/raspberrypi/controller/rpi/geq.cpp     |  4 ++--
>  .../controller/rpi/{geq.hpp => geq.h}          |  4 ++--
>  src/ipa/raspberrypi/controller/rpi/lux.cpp     |  2 +-
>  .../controller/rpi/{lux.hpp => lux.h}          |  4 ++--
>  src/ipa/raspberrypi/controller/rpi/noise.cpp   |  2 +-
>  .../controller/rpi/{noise.hpp => noise.h}      |  4 ++--
>  src/ipa/raspberrypi/controller/rpi/sdn.cpp     |  2 +-
>  .../controller/rpi/{sdn.hpp => sdn.h}          |  6 +++---
>  src/ipa/raspberrypi/controller/rpi/sharpen.cpp |  2 +-
>  .../controller/rpi/{sharpen.hpp => sharpen.h}  |  4 ++--
>  ...arpen_algorithm.hpp => sharpen_algorithm.h} |  4 ++--
>  .../raspberrypi/{md_parser.hpp => md_parser.h} |  2 +-
>  src/ipa/raspberrypi/md_parser_smia.cpp         |  2 +-
>  src/ipa/raspberrypi/raspberrypi.cpp            | 18 +++++++++---------
>  53 files changed, 101 insertions(+), 101 deletions(-)
>  rename src/ipa/raspberrypi/{cam_helper.hpp => cam_helper.h} (96%)
>  rename src/ipa/raspberrypi/controller/{agc_algorithm.hpp => agc_algorithm.h} (92%)
>  rename src/ipa/raspberrypi/controller/{algorithm.hpp => algorithm.h} (95%)
>  rename src/ipa/raspberrypi/controller/{awb_algorithm.hpp => awb_algorithm.h} (86%)
>  rename src/ipa/raspberrypi/controller/{ccm_algorithm.hpp => ccm_algorithm.h} (78%)
>  rename src/ipa/raspberrypi/controller/{contrast_algorithm.hpp => contrast_algorithm.h} (82%)
>  rename src/ipa/raspberrypi/controller/{controller.hpp => controller.h} (95%)
>  rename src/ipa/raspberrypi/controller/{denoise_algorithm.hpp => denoise_algorithm.h} (86%)
>  rename src/ipa/raspberrypi/controller/{histogram.hpp => histogram.h} (96%)
>  rename src/ipa/raspberrypi/controller/{metadata.hpp => metadata.h} (98%)
>  rename src/ipa/raspberrypi/controller/{pwl.hpp => pwl.h} (98%)
>  rename src/ipa/raspberrypi/controller/rpi/{agc.hpp => agc.h} (97%)
>  rename src/ipa/raspberrypi/controller/rpi/{alsc.hpp => alsc.h} (97%)
>  rename src/ipa/raspberrypi/controller/rpi/{awb.hpp => awb.h} (98%)
>  rename src/ipa/raspberrypi/controller/rpi/{black_level.hpp => black_level.h} (88%)
>  rename src/ipa/raspberrypi/controller/rpi/{ccm.hpp => ccm.h} (93%)
>  rename src/ipa/raspberrypi/controller/rpi/{contrast.hpp => contrast.h} (90%)
>  rename src/ipa/raspberrypi/controller/rpi/{dpc.hpp => dpc.h} (85%)
>  rename src/ipa/raspberrypi/controller/rpi/{focus.hpp => focus.h} (85%)
>  rename src/ipa/raspberrypi/controller/rpi/{geq.hpp => geq.h} (88%)
>  rename src/ipa/raspberrypi/controller/rpi/{lux.hpp => lux.h} (94%)
>  rename src/ipa/raspberrypi/controller/rpi/{noise.hpp => noise.h} (91%)
>  rename src/ipa/raspberrypi/controller/rpi/{sdn.hpp => sdn.h} (84%)
>  rename src/ipa/raspberrypi/controller/rpi/{sharpen.hpp => sharpen.h} (90%)
>  rename src/ipa/raspberrypi/controller/{sharpen_algorithm.hpp => sharpen_algorithm.h} (82%)
>  rename src/ipa/raspberrypi/{md_parser.hpp => md_parser.h} (98%)

[snip]

-- 
Regards,

Laurent Pinchart


More information about the libcamera-devel mailing list