[libcamera-devel] [PATCH v5 0/2] cam: Replace dependency on SDL2_image with libjpeg

[Eric Curtin]

@Kieran Bingham and @Ian Mullins

If you get a spare moment, would you like to do a quick review?

Is mise le meas/Regards,

Eric Curtin


On Tue, 26 Jul 2022 at 23:14, Laurent Pinchart
<laurent.pinchart at ideasonboard.com> wrote:
>
> Hi Eric,
>
> On Tue, Jul 26, 2022 at 10:52:14PM +0100, Eric Curtin wrote:
> > I'd add review-by tags or tested-by tags but I'm also Co-Author, would feel
> > wrong lol.
> >
> > Just a reminder about this patch set.
>
> Ping for other reviewers :-)
>
> > On Wed 20 Jul 2022, 15:54 Eric Curtin wrote:
> >
> > > On Wed, 20 Jul 2022 at 14:04, Laurent Pinchart wrote:
> > > >
> > > > Hello,
> > > >
> > > > This patch series bundles a new version of Eric's SDL2_image replacement
> > > > with an additional cleanup for the cam SDL support. I've numbered it v5
> > > > as Eric's patch (now 1/2) was v4, but patch 2/2 is new.
> > > >
> > > > The changes in 1/2 just incorporates my review comments, I've decided to
> > > > send the result as I had already made the changes locally to test the
> > > > review recommedations.
> > > >
> > > > Eric, please feel free to disagree with any of the changes :-)
> > > > Otherwise, if you're OK with them, I'll apply the series.
> > >
> > > I tested and reviewed the patches, all good on my end!
> > >
> > > >
> > > > Eric Curtin (1):
> > > >   cam: sdl_sink: Use libjpeg over SDL2_image
> > > >
> > > > Laurent Pinchart (1):
> > > >   cam: sdl_sink: Pass a Span<const uint8_t> to SDLTexture::update()
> > > >
> > > >  README.rst                   |  2 +-
> > > >  src/cam/meson.build          |  8 ++--
> > > >  src/cam/sdl_sink.cpp         |  4 +-
> > > >  src/cam/sdl_texture.h        |  2 +-
> > > >  src/cam/sdl_texture_mjpg.cpp | 72 ++++++++++++++++++++++++++++++++----
> > > >  src/cam/sdl_texture_mjpg.h   |  8 +++-
> > > >  src/cam/sdl_texture_yuyv.cpp |  2 +-
> > > >  src/cam/sdl_texture_yuyv.h   |  2 +-
> > > >  8 files changed, 82 insertions(+), 18 deletions(-)
> > > >
> > > >
> > > > base-commit: 8b02645845bf404fba83910818b285b652f14f89
>
> --
> Regards,
>
> Laurent Pinchart
>