[libcamera-devel] [PATCH] ipa: raspberrypi: Remove unused Controller constructor

Naushir Patuck naush at raspberrypi.com
Thu Jul 28 14:04:39 CEST 2022


The Controller(char const *jsonFilename) is not valid anymore since
Controller::read() can now return an error on a failure. Additionally, this
constructure is not actually used, so remove it.

Signed-off-by: Naushir Patuck <naush at raspberrypi.com>
---
 src/ipa/raspberrypi/controller/controller.cpp | 7 -------
 src/ipa/raspberrypi/controller/controller.h   | 1 -
 2 files changed, 8 deletions(-)

diff --git a/src/ipa/raspberrypi/controller/controller.cpp b/src/ipa/raspberrypi/controller/controller.cpp
index bbd382bce3ab..f489278668ef 100644
--- a/src/ipa/raspberrypi/controller/controller.cpp
+++ b/src/ipa/raspberrypi/controller/controller.cpp
@@ -25,13 +25,6 @@ Controller::Controller()
 {
 }
 
-Controller::Controller(char const *jsonFilename)
-	: switchModeCalled_(false)
-{
-	read(jsonFilename);
-	initialise();
-}
-
 Controller::~Controller() {}
 
 int Controller::read(char const *filename)
diff --git a/src/ipa/raspberrypi/controller/controller.h b/src/ipa/raspberrypi/controller/controller.h
index 6be1e3cfa156..3e1e051703b3 100644
--- a/src/ipa/raspberrypi/controller/controller.h
+++ b/src/ipa/raspberrypi/controller/controller.h
@@ -40,7 +40,6 @@ class Controller
 {
 public:
 	Controller();
-	Controller(char const *jsonFilename);
 	~Controller();
 	int read(char const *filename);
 	void initialise();
-- 
2.25.1



More information about the libcamera-devel mailing list