[libcamera-devel] [PATCH] ipa: raspberrypi: Remove unused Controller constructor

[Kieran Bingham]

Quoting Naushir Patuck via libcamera-devel (2022-07-28 13:05:30)
> The Controller(char const *jsonFilename) is not valid anymore since
> Controller::read() can now return an error on a failure. Additionally, this
> constructor is not actually used, so remove it.
> 


Reviewed-by: Kieran Bingham <kieran.bingham at ideasonboard.com>

> Signed-off-by: Naushir Patuck <naush at raspberrypi.com>
> ---
>  src/ipa/raspberrypi/controller/controller.cpp | 7 -------
>  src/ipa/raspberrypi/controller/controller.h   | 1 -
>  2 files changed, 8 deletions(-)
> 
> diff --git a/src/ipa/raspberrypi/controller/controller.cpp b/src/ipa/raspberrypi/controller/controller.cpp
> index bbd382bce3ab..f489278668ef 100644
> --- a/src/ipa/raspberrypi/controller/controller.cpp
> +++ b/src/ipa/raspberrypi/controller/controller.cpp
> @@ -25,13 +25,6 @@ Controller::Controller()
>  {
>  }
>  
> -Controller::Controller(char const *jsonFilename)
> -       : switchModeCalled_(false)
> -{
> -       read(jsonFilename);
> -       initialise();
> -}
> -
>  Controller::~Controller() {}
>  
>  int Controller::read(char const *filename)
> diff --git a/src/ipa/raspberrypi/controller/controller.h b/src/ipa/raspberrypi/controller/controller.h
> index 6be1e3cfa156..3e1e051703b3 100644
> --- a/src/ipa/raspberrypi/controller/controller.h
> +++ b/src/ipa/raspberrypi/controller/controller.h
> @@ -40,7 +40,6 @@ class Controller
>  {
>  public:
>         Controller();
> -       Controller(char const *jsonFilename);
>         ~Controller();
>         int read(char const *filename);
>         void initialise();
> -- 
> 2.25.1
>