[libcamera-devel] [PATCH v5 0/4] generate and use fixed-sized Span Control types

[Laurent Pinchart]

Hi Christian,

On Thu, Jun 02, 2022 at 12:17:58AM +0100, Christian Rauch via libcamera-devel wrote:
> Hello,
> 
> This is the rebased version of my patch set with minor modifications
> for an additional control value that was added in the meantime. I
> additionally prefixed and capitalised the commit messages to follow
> the estalished commit style.
> 
> The last remaining concern was about the use of "std::optional". This
> has been resolved now by accepting std::optional in the public API.

I'm getting lots of compilation errors in the Android camera HAL
implementation (src/android/). Could you enable compilation of that
component (meson configure -D android=enabled) and fix them ?

> Christian Rauch (4):
>   libcamera: controls: Use std::optional to handle invalid control
>     values
>   libcamera: controls: Define size of array controls as a shape vector
>   libcamera: controls: Generate fixed- and variable-sized Span Controls
>   libcamera: controls: Apply explicit fixed-sized Span type casts
> 
>  include/libcamera/controls.h                  |  7 ++--
>  src/cam/main.cpp                              |  4 +--
>  src/ipa/raspberrypi/raspberrypi.cpp           | 21 ++++++------
>  src/libcamera/control_ids.yaml                |  4 +--
>  src/libcamera/pipeline/ipu3/ipu3.cpp          |  9 +++---
>  .../pipeline/raspberrypi/raspberrypi.cpp      | 10 +++---
>  src/libcamera/property_ids.yaml               |  4 +--
>  src/qcam/dng_writer.cpp                       | 15 +++++----
>  utils/gen-controls.py                         | 32 +++++++++++++------
>  9 files changed, 62 insertions(+), 44 deletions(-)

-- 
Regards,

Laurent Pinchart