[libcamera-devel] [PATCH v3 2/5] android: camera_stream: Create allocator unconditionally
Jacopo Mondi
jacopo at jmondi.org
Sat Jun 4 11:30:22 CEST 2022
Originally buffer allocation was only required for Internal streams
which are not backed by a frame buffer provided by the Android
framework.
Now that mapped streams can be generated without the corresponding
source stream being part of the Android's provided stream list, also
buffers of type Mapped can be required to allocate buffers on demand.
Create CameraStream::allocator_ and the associated mutex unconditionally
for all types of stream.
Signed-off-by: Jacopo Mondi <jacopo at jmondi.org>
Reviewed-by: Umang Jain <umang.jain at ideasonboard.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>
---
src/android/camera_stream.cpp | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/src/android/camera_stream.cpp b/src/android/camera_stream.cpp
index 154e088e1b86..045e60061a20 100644
--- a/src/android/camera_stream.cpp
+++ b/src/android/camera_stream.cpp
@@ -128,10 +128,8 @@ int CameraStream::configure()
worker_->start();
}
- if (type_ == Type::Internal) {
- allocator_ = std::make_unique<PlatformFrameBufferAllocator>(cameraDevice_);
- mutex_ = std::make_unique<Mutex>();
- }
+ allocator_ = std::make_unique<PlatformFrameBufferAllocator>(cameraDevice_);
+ mutex_ = std::make_unique<Mutex>();
camera3Stream_->max_buffers = configuration().bufferCount;
--
2.35.1
More information about the libcamera-devel
mailing list