[libcamera-devel] [RFC PATCH v2 04/14] test: yaml-parser: Use write() instead of fwrite()
Laurent Pinchart
laurent.pinchart at ideasonboard.com
Sat Jun 4 20:59:29 CEST 2022
There's no point in wrapping a fd into a FILE to then only call fwrite()
and fclose(). Use write() and close() directly.
Signed-off-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>
---
test/yaml-parser.cpp | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/test/yaml-parser.cpp b/test/yaml-parser.cpp
index e75f8fe8f642..5ff4c3236dbf 100644
--- a/test/yaml-parser.cpp
+++ b/test/yaml-parser.cpp
@@ -49,10 +49,11 @@ protected:
if (fd == -1)
return false;
- FILE *fh = fdopen(fd, "w");
- fputs(content.c_str(), fh);
+ int ret = write(fd, content.c_str(), content.size());
+ close(fd);
- fclose(fh);
+ if (ret != static_cast<int>(content.size()))
+ return false;
return true;
}
--
Regards,
Laurent Pinchart
More information about the libcamera-devel
mailing list