[libcamera-devel] [PATCH v7 0/5] generate and use fixed-sized Span Control types

Christian Rauch Rauch.Christian at gmx.de
Sat Jun 4 23:11:43 CEST 2022


Hello,

Compared to the previous version, this 1) avoids a couple of more "value_or" fallbacks if the validity of a control value or property was previously checked with "contains" and 2) avoids references to potential invalid control values or properties. The last point fixes compiler errors reported by clang.

Best,

Christian Rauch (5):
  libcamera: controls: Use std::optional to handle invalid control
    values
  libcamera: ipu3: Fix rogue whitespace
  libcamera: controls: Define size of array controls as a shape vector
  libcamera: controls: Generate fixed- and variable-sized Span Controls
  libcamera: controls: Apply explicit fixed-sized Span type casts

 include/libcamera/controls.h                  |  7 ++--
 src/android/camera_capabilities.cpp           | 12 +++----
 src/android/camera_device.cpp                 | 21 ++++++------
 src/android/camera_hal_manager.cpp            |  2 +-
 src/cam/main.cpp                              |  4 +--
 src/ipa/raspberrypi/raspberrypi.cpp           | 21 ++++++------
 src/libcamera/control_ids.yaml                |  4 +--
 src/libcamera/pipeline/ipu3/ipu3.cpp          | 11 +++----
 .../pipeline/raspberrypi/raspberrypi.cpp      |  9 +++---
 src/libcamera/property_ids.yaml               |  4 +--
 src/qcam/dng_writer.cpp                       | 22 ++++++-------
 utils/gen-controls.py                         | 32 +++++++++++++------
 12 files changed, 81 insertions(+), 68 deletions(-)

--
2.34.1


More information about the libcamera-devel mailing list