[libcamera-devel] [PATCH v6 1/5] libcamera: controls: Use std::optional to handle invalid control values

[Kieran Bingham]

Hi All,

Quoting Jacopo Mondi via libcamera-devel (2022-06-05 10:13:32)
> > > I guess the issue might be due to taking a reference to a temporary
> > > value as:
> > > const Size cellSize = *properties.get(properties::UnitCellSize);
> > >
> > > as well as:
> > > const Size &cellSize = properties.get(properties::UnitCellSize).value_or(Size{});;
> > >
> > > compile fine.
> >
> > Thanks for pointing this out. I could reproduce this with clang
> > ("CC=clang CXX=clang++ meson build -Dandroid=enabled") but not with gcc.
> > Even "-Dwarning_level=3" did not show these errors.
> >
> > Does libcamera run a build server somewhere? This would be helpful to
> > discover errors in non-standard configurations (e.g. with clang in this
> > case or with "android" enabled).
> >
> 
> Unfortunately not for public use. I run a buildbot instance as a best
> effort service for internal (aka people who can push to master)
> pre-integration testing. It's not stable or maintained well enough
> for public usage yet.
> 
> We do also have the linux-media Jenkins instance, but that only runs
> on master afaict

And I have my build machine too.

I think one possible solution would be to get a gitlab instance on
freedesktop.org and add a .gitlab-ci.yml - this could then trigger build
jobs for others to push to a gitlab instance.

I tried setting up and maintaining my own gitlab instance, but that
lasted a week before it fell over :S ... so I don't want to run one
myself. If we can use an external such as F.D.O that will help.

--
Kieran