[libcamera-devel] [PATCH v2 1/5] libcamera: pipeline: simple: Improve debug message on config failure

[Kieran Bingham]

Quoting Laurent Pinchart via libcamera-devel (2022-06-12 16:23:07)
> When pipeline configuration fails, print the format returned by the
> kernel in addition to the one requested by libcamera, to ease debugging.
> 
> Signed-off-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>

Reviewed-by: Kieran Bingham <kieran.bingham at ideasonboard.com>

> ---
>  src/libcamera/pipeline/simple/simple.cpp | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/src/libcamera/pipeline/simple/simple.cpp b/src/libcamera/pipeline/simple/simple.cpp
> index de75465eb3b5..efb28ccd97e8 100644
> --- a/src/libcamera/pipeline/simple/simple.cpp
> +++ b/src/libcamera/pipeline/simple/simple.cpp
> @@ -939,7 +939,8 @@ int SimplePipelineHandler::configure(Camera *camera, CameraConfiguration *c)
>             captureFormat.size != pipeConfig->captureSize) {
>                 LOG(SimplePipeline, Error)
>                         << "Unable to configure capture in "
> -                       << pipeConfig->captureSize << "-" << videoFormat;
> +                       << pipeConfig->captureSize << "-" << videoFormat
> +                       << " (got " << captureFormat << ")";
>                 return -EINVAL;
>         }
>  
> -- 
> Regards,
> 
> Laurent Pinchart
>