[libcamera-devel] [PATCH v2 4/5] ipa: rkisp1: Add ov5640 tuning file

[Laurent Pinchart]

Hi Florian,

Thank you for the patch.

On Thu, Jun 16, 2022 at 10:07:43AM +0200, Florian Sylvestre via libcamera-devel wrote:
> Add the ov5640 tuning file containing default values for 'black level
> correction' algorithm.
> 
> Signed-off-by: Florian Sylvestre <fsylvestre at baylibre.com>
> ---
>  src/ipa/rkisp1/data/meson.build | 8 ++++++++
>  src/ipa/rkisp1/data/ov5640.yaml | 8 ++++++++
>  src/ipa/rkisp1/meson.build      | 1 +
>  3 files changed, 17 insertions(+)
>  create mode 100644 src/ipa/rkisp1/data/meson.build
>  create mode 100644 src/ipa/rkisp1/data/ov5640.yaml
> 
> diff --git a/src/ipa/rkisp1/data/meson.build b/src/ipa/rkisp1/data/meson.build
> new file mode 100644
> index 00000000..2656bb2e
> --- /dev/null
> +++ b/src/ipa/rkisp1/data/meson.build
> @@ -0,0 +1,8 @@
> +# SPDX-License-Identifier: CC0-1.0
> +
> +conf_files = files([
> +    'ov5640.yaml',
> +])
> +
> +install_data(conf_files,
> +             install_dir : ipa_data_dir / 'rkisp1')
> diff --git a/src/ipa/rkisp1/data/ov5640.yaml b/src/ipa/rkisp1/data/ov5640.yaml
> new file mode 100644
> index 00000000..d8e56463
> --- /dev/null
> +++ b/src/ipa/rkisp1/data/ov5640.yaml
> @@ -0,0 +1,8 @@
> +# SPDX-License-Identifier: CC0-1.0

%YAML 1.2

> +---
> +BlackLevelCorrection:
> +  R:  256
> +  Gr: 256
> +  Gb: 256
> +  B:  256
> +...

Following a discussion with Naush and David about the Raspberry Pi
tuning files, it became clear versioning them would be useful. I'd thus
propose the following:

version: 1
algorithms:
  - BlackLevelCorrection:
      R:  256
      Gr: 256
      Gb: 256
      B:  256

The algorithms should be put in a list to support instantiating them in
user-configurable order if needed, as YAML mappings are not ordered.

> diff --git a/src/ipa/rkisp1/meson.build b/src/ipa/rkisp1/meson.build
> index 8c822fbb..ccb84b27 100644
> --- a/src/ipa/rkisp1/meson.build
> +++ b/src/ipa/rkisp1/meson.build
> @@ -1,6 +1,7 @@
>  # SPDX-License-Identifier: CC0-1.0
>  
>  subdir('algorithms')
> +subdir('data')
>  
>  ipa_name = 'ipa_rkisp1'
>  

-- 
Regards,

Laurent Pinchart