[libcamera-devel] [PATCH v2 2/3] Documentation: Update code examples to use the Request::reuse() method

Daniel Semkowicz dse at thaumatec.com
Fri Jun 17 16:35:48 CEST 2022


After introduction of reuse(), there is no need of manual request
reconfiguration. Furthermore, current example code does not work
anymore.

Signed-off-by: Daniel Semkowicz <dse at thaumatec.com>
---
 .../guides/application-developer.rst          | 20 +++----------------
 1 file changed, 3 insertions(+), 17 deletions(-)

diff --git a/Documentation/guides/application-developer.rst b/Documentation/guides/application-developer.rst
index 6ab8b7e5..a5f363cf 100644
--- a/Documentation/guides/application-developer.rst
+++ b/Documentation/guides/application-developer.rst
@@ -480,26 +480,12 @@ libcamera repository.
 .. _FileSink class: https://git.libcamera.org/libcamera/libcamera.git/tree/src/cam/file_sink.cpp
 
 With the handling of this request completed, it is possible to re-use the
-buffers by adding them to a new ``Request`` instance with their matching
-streams, and finally, queue the new capture request to the camera device:
+request and the associated buffers and re-queue it to the camera
+device:
 
 .. code:: cpp
 
-   request = camera->createRequest();
-   if (!request)
-   {
-       std::cerr << "Can't create request" << std::endl;
-       return;
-   }
-
-   for (auto it = buffers.begin(); it != buffers.end(); ++it)
-   {
-       Stream *stream = it->first;
-       FrameBuffer *buffer = it->second;
-
-       request->addBuffer(stream, buffer);
-   }
-
+   request->reuse(Request::ReuseBuffers);
    camera->queueRequest(request);
 
 Request queueing
-- 
2.34.1



More information about the libcamera-devel mailing list