[libcamera-devel] [PATCH 1/7] libcamera: yaml_parser: Use std::is_same_v<>

Hanlin Chen hanlinchen at chromium.org
Mon Jun 20 14:08:32 CEST 2022


Hi Laurent,

Reviewed-by: Han-Lin Chen <hanlinchen at chromium.org>
Thanks.

On Thu, Jun 16, 2022 at 10:24 PM Laurent Pinchart via libcamera-devel
<libcamera-devel at lists.libcamera.org> wrote:
>
> As the YamlObject class is internal to libcamera, it can use the full
> C++17 API. Replace std::is_same<>::value with std::is_same_v<>.
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>
> ---
>  include/libcamera/internal/yaml_parser.h | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/include/libcamera/internal/yaml_parser.h b/include/libcamera/internal/yaml_parser.h
> index be5f0914703f..29b7b218f0d9 100644
> --- a/include/libcamera/internal/yaml_parser.h
> +++ b/include/libcamera/internal/yaml_parser.h
> @@ -44,12 +44,12 @@ public:
>  #ifndef __DOXYGEN__
>         template<typename T,
>                  typename std::enable_if_t<
> -                        std::is_same<bool, T>::value ||
> -                        std::is_same<double, T>::value ||
> -                        std::is_same<int32_t, T>::value ||
> -                        std::is_same<uint32_t, T>::value ||
> -                        std::is_same<std::string, T>::value ||
> -                        std::is_same<Size, T>::value> * = nullptr>
> +                        std::is_same_v<bool, T> ||
> +                        std::is_same_v<double, T> ||
> +                        std::is_same_v<int32_t, T> ||
> +                        std::is_same_v<uint32_t, T> ||
> +                        std::is_same_v<std::string, T> ||
> +                        std::is_same_v<Size, T>> * = nullptr>
>  #else
>         template<typename T>
>  #endif
> --
> Regards,
>
> Laurent Pinchart
>


More information about the libcamera-devel mailing list