[libcamera-devel] [PATCH v4 06/12] ipa: libipa: module: Make the Module class Loggable

paul.elder at ideasonboard.com paul.elder at ideasonboard.com
Thu Jun 23 09:51:04 CEST 2022


Hi Laurent,

On Mon, Jun 20, 2022 at 04:42:59AM +0300, Laurent Pinchart wrote:
> To help attribute messages logged by the Module class to a particular
> IPA module, make the class loggable and add a name argument to its
> constructor to specify the log prefix.

Where's the logPrefix? And the name argument to the constructor?

Paul

> 
> Signed-off-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>
> ---
>  src/ipa/libipa/module.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/ipa/libipa/module.h b/src/ipa/libipa/module.h
> index 00d5785e1aa0..cd67912f1b0c 100644
> --- a/src/ipa/libipa/module.h
> +++ b/src/ipa/libipa/module.h
> @@ -27,7 +27,7 @@ namespace ipa {
>  
>  template<typename _Context, typename _FrameContext, typename _Config,
>  	 typename _Params, typename _Stats>
> -class Module
> +class Module : public Loggable
>  {
>  public:
>  	using Context = _Context;


More information about the libcamera-devel mailing list