[libcamera-devel] [PATCH v4 08/12] ipa: rkisp1: Register algorithms

paul.elder at ideasonboard.com paul.elder at ideasonboard.com
Thu Jun 23 10:47:10 CEST 2022


Hi Laurent,

On Mon, Jun 20, 2022 at 04:43:01AM +0300, Laurent Pinchart wrote:
> To prepare for dynamic instantiation of algorithms from the tuning file,
> register the algorithms with the Module class.
> 
> Signed-off-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>

Reviewed-by: Paul Elder <paul.elder at ideasonboard.com>

> ---
>  src/ipa/rkisp1/algorithms/agc.cpp | 2 ++
>  src/ipa/rkisp1/algorithms/awb.cpp | 2 ++
>  src/ipa/rkisp1/algorithms/blc.cpp | 2 ++
>  3 files changed, 6 insertions(+)
> 
> diff --git a/src/ipa/rkisp1/algorithms/agc.cpp b/src/ipa/rkisp1/algorithms/agc.cpp
> index 9a12e93ae4c7..6bfe4375b396 100644
> --- a/src/ipa/rkisp1/algorithms/agc.cpp
> +++ b/src/ipa/rkisp1/algorithms/agc.cpp
> @@ -355,6 +355,8 @@ void Agc::prepare(IPAContext &context, rkisp1_params_cfg *params)
>  	params->module_en_update |= RKISP1_CIF_ISP_MODULE_HST;
>  }
>  
> +REGISTER_IPA_ALGORITHM(Agc)
> +
>  } /* namespace ipa::rkisp1::algorithms */
>  
>  } /* namespace libcamera */
> diff --git a/src/ipa/rkisp1/algorithms/awb.cpp b/src/ipa/rkisp1/algorithms/awb.cpp
> index 884413828d1d..852d8559aa8a 100644
> --- a/src/ipa/rkisp1/algorithms/awb.cpp
> +++ b/src/ipa/rkisp1/algorithms/awb.cpp
> @@ -175,6 +175,8 @@ void Awb::process([[maybe_unused]] IPAContext &context,
>  			      << " and for blue: " << context.frameContext.awb.gains.blue;
>  }
>  
> +REGISTER_IPA_ALGORITHM(Awb)
> +
>  } /* namespace ipa::rkisp1::algorithms */
>  
>  } /* namespace libcamera */
> diff --git a/src/ipa/rkisp1/algorithms/blc.cpp b/src/ipa/rkisp1/algorithms/blc.cpp
> index 0c5948ff2c02..ea9611bd712e 100644
> --- a/src/ipa/rkisp1/algorithms/blc.cpp
> +++ b/src/ipa/rkisp1/algorithms/blc.cpp
> @@ -52,6 +52,8 @@ void BlackLevelCorrection::prepare(IPAContext &context,
>  	params->module_cfg_update |= RKISP1_CIF_ISP_MODULE_BLS;
>  }
>  
> +REGISTER_IPA_ALGORITHM(BlackLevelCorrection)
> +
>  } /* namespace ipa::rkisp1::algorithms */
>  
>  } /* namespace libcamera */


More information about the libcamera-devel mailing list