[libcamera-devel] [PATCH 0/3] Add SensorTemperature control

[Jean-Michel Hautbois]

On 23/06/2022 16:50, Jean-Michel Hautbois via libcamera-devel wrote:
> Hi Naushir,
> 
> Thanks for the series !
> 
> On 23/06/2022 16:44, Naushir Patuck via libcamera-devel wrote:
>> Hi,
>>
>> This series adds a sensor temperature metadata control to libcamera.  
>> This
>> control is returned out through Request metadata when available.  
>> There is an
>> open PR [1] to enable the temperature sensor on the imx477 on the 
>> Raspberry Pi
>> platforms.
>>
>> At present, there is no mechanism in V4L2 to return the temperature 
>> from the
>> sensor device driver, so we rely on the embedded data to fetch the 
>> values every
>> frame.
> 
> I think this PR along with a V4L2 control introduction 
> (V4L2_CID_TEMPERATURE :-) ?) could be interesting to be sent to the 
> linux-media ML at the same time ?

I forgot to ask the use case though ? :-)

> 
> JM
> 
>>
>> Thanks,
>> Naush
>>
>> [1] https://github.com/raspberrypi/linux/pull/5067
>>
>> Naushir Patuck (3):
>>    libcamera: controls: Add SensorTemperature control
>>    ipa: raspberrypi: Add sensor temperature to DeviceStatus
>>    ipa: raspberrypi: imx477: Get sensor temperature from embedded data
>>
>>   src/ipa/raspberrypi/cam_helper.cpp               |  7 ++++---
>>   src/ipa/raspberrypi/cam_helper_imx477.cpp        |  5 ++++-
>>   src/ipa/raspberrypi/controller/device_status.cpp |  3 +++
>>   src/ipa/raspberrypi/controller/device_status.h   |  4 +++-
>>   src/ipa/raspberrypi/raspberrypi.cpp              |  2 ++
>>   src/libcamera/control_ids.yaml                   | 10 ++++++++++
>>   6 files changed, 26 insertions(+), 5 deletions(-)
>>