[libcamera-devel] [PATCH] py: Honour the pycamera meson option

[Javier Martinez Canillas]

Hello Laurent,

On 6/23/22 19:06, Laurent Pinchart wrote:
> Hello,
> 
> On Thu, Jun 23, 2022 at 05:25:56PM +0100, Kieran Bingham wrote:
>> Quoting Javier Martinez Canillas (2022-06-23 13:41:40)
>>> The libcamera Python bindings are attempted to be built unconditionally,
>>> even when there is a meson feature option to disable it. Make the meson
>>> build file in the sub-dir to exit earlier if pycamera has been disabled.
>>
>> s/ to exit/ exit/
>>
>> Seems reasonable, I wonder if there are other components that don't
>> adhere to the disabled option too, as I expect the dep.found() pattern
>> is used elsewhere. And the 'disabled' only makes it optional to find it
>> (which it still can).
>>
>> Any interest in checking other uses to go along side this? (Probably as
>> one patch) - otherwise, merging this if agreed should still be a
>> resolution to the current issue.
> 
> https://mesonbuild.com/Build-options.html#features
> 
> "disabled do not look for the dependency and always return 'not-found'."
> 
> I've just tested it, and I confirm the behaviour. If I set pycamera to
> disabled, then it doesn't get built, even if the dependency exists.
> 
You are right. I just tested dropping this patch from the package and it
does indeed still build. I wonder why it failed for me before that lead
me to write this patch. Maybe I did something silly when testing my pkg
build...

Feel free to discard this patch, sorry to the noise.

-- 
Best regards,

Javier Martinez Canillas
Linux Engineering
Red Hat