[libcamera-devel] [PATCH 06/13] gstreamer: Rename queued requests queue to queuedRequests_

Laurent Pinchart laurent.pinchart at ideasonboard.com
Fri Jun 24 01:22:03 CEST 2022


To prepare for the addition of a completed requests queue, rename the
existing queued requests queue from requests_ to queuedRequests_.

Signed-off-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>
---
 src/gstreamer/gstlibcamerasrc.cpp | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/gstreamer/gstlibcamerasrc.cpp b/src/gstreamer/gstlibcamerasrc.cpp
index a1fab71d4f09..02fc913764f8 100644
--- a/src/gstreamer/gstlibcamerasrc.cpp
+++ b/src/gstreamer/gstlibcamerasrc.cpp
@@ -108,7 +108,7 @@ struct GstLibcameraSrcState {
 	std::shared_ptr<Camera> cam_;
 	std::unique_ptr<CameraConfiguration> config_;
 	std::vector<GstPad *> srcpads_;
-	std::queue<std::unique_ptr<RequestWrap>> requests_;
+	std::queue<std::unique_ptr<RequestWrap>> queuedRequests_;
 	guint group_id_;
 
 	void requestCompleted(Request *request);
@@ -155,8 +155,8 @@ GstLibcameraSrcState::requestCompleted(Request *request)
 
 	GST_DEBUG_OBJECT(src_, "buffers are ready");
 
-	std::unique_ptr<RequestWrap> wrap = std::move(requests_.front());
-	requests_.pop();
+	std::unique_ptr<RequestWrap> wrap = std::move(queuedRequests_.front());
+	queuedRequests_.pop();
 
 	g_return_if_fail(wrap->request_.get() == request);
 
@@ -311,7 +311,7 @@ gst_libcamera_src_task_run(gpointer user_data)
 		GLibLocker lock(GST_OBJECT(self));
 		GST_TRACE_OBJECT(self, "Requesting buffers");
 		state->cam_->queueRequest(wrap->request_.get());
-		state->requests_.push(std::move(wrap));
+		state->queuedRequests_.push(std::move(wrap));
 
 		/* The RequestWrap will be deleted in the completion handler. */
 	}
-- 
Regards,

Laurent Pinchart



More information about the libcamera-devel mailing list