[libcamera-devel] [PATCH] README: Add some extra optional dependancies for cam sinks

[Eric Curtin]

Yeah I'm happy with that!

Is mise le meas/Regards,

Eric Curtin



On Fri, 24 Jun 2022 at 13:47, Kieran Bingham <
kieran.bingham at ideasonboard.com> wrote:

> Quoting Eric Curtin (2022-06-23 19:45:39)
> > I think this ones an easy review if someone gets the chance.
> >
> > Is mise le meas/Regards,
> >
> > Eric Curtin
> >
> >
> > On Wed, 22 Jun 2022 at 15:38, Eric Curtin <ecurtin at redhat.com> wrote:
> > >
> > > KMS sink requires some DRM libraries, SDL sink requires some SDL
> > > libraries.
> > >
> > > Suggested-by: Pavel Machek <pavel at ucw.cz>
> > > Signed-off-by: Eric Curtin <ecurtin at redhat.com>
> > > ---
> > > Changes in v2:
> > >
> > > - Updated commit message/
> > > ---
> > >  README.rst | 8 +++++++-
> > >  1 file changed, 7 insertions(+), 1 deletion(-)
> > >
> > > diff --git a/README.rst b/README.rst
> > > index 05ebcec4..28c79b3f 100644
> > > --- a/README.rst
> > > +++ b/README.rst
> > > @@ -87,7 +87,13 @@ for gstreamer: [optional]
> > >          libgstreamer1.0-dev libgstreamer-plugins-base1.0-dev
> > >
> > >  for cam: [optional]
> > > -        libevent-dev
> > > +        libevent-dev libdrm-dev libsdl2-dev libsdl2-image-dev
>
> Should we wrap optional dependencies in [ ] ?
> Cam is optional (hence the [optional]) but now the optional component
> has optional dependencies!?
>
> > > +
> > > +        If you would like to use KMS sink libdrm-dev is an optional
> dependancy,
> > > +        if you would like to use SDL sink with pixel formats such as
> YUYV,
> > > +        libsdl2-dev is an optional dependancy, if you would like to
> use SDL
> > > +        sink with pixel formats such as MJPEG, libsdl2-image-dev is an
> > > +        optional dependancy.
>
> This is quite some terse reading.
>
> In an effort to make it easier I'll have a go:
>
>         libevent-dev is required to support cam, however the following
>         optional dependencies bring more functionality to the cam test
>         tool:
>
>         libdrm-dev: Enables the KMS sink
>         libsdl2-dev: Enables the SDL sink
>         libsdl2-image-dev: Supports MJPEG on the SDL sink
>
>
> > >
> > >  for qcam: [optional]
> > >          qtbase5-dev libqt5core5a libqt5gui5 libqt5widgets5
> qttools5-dev-tools libtiff-dev
> > > --
> > > 2.35.3
> > >
> >
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.libcamera.org/pipermail/libcamera-devel/attachments/20220624/e7130872/attachment.htm>