[libcamera-devel] [PATCH v2] README: Add some extra optional dependancies for cam sinks

[Laurent Pinchart]

On Mon, Jun 27, 2022 at 10:12:14AM +0200, Jacopo Mondi wrote:
> Hi Laurent
> 
> On Sat, Jun 25, 2022 at 02:15:53AM +0300, Laurent Pinchart via libcamera-devel wrote:
> > From: Eric Curtin <ecurtin at redhat.com>
> >
> > KMS sink requires some DRM libraries, SDL sink requires some SDL
> > libraries.
> >
> > Suggested-by: Pavel Machek <pavel at ucw.cz>
> > Signed-off-by: Eric Curtin <ecurtin at redhat.com>
> > Signed-off-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>
> > ---
> > A v2 just to make sure we're on the same page.
> >
> >  README.rst | 8 +++++++-
> >  1 file changed, 7 insertions(+), 1 deletion(-)
> >
> > diff --git a/README.rst b/README.rst
> > index 05ebcec4c4c1..b9e72d81b90c 100644
> > --- a/README.rst
> > +++ b/README.rst
> > @@ -87,7 +87,13 @@ for gstreamer: [optional]
> >          libgstreamer1.0-dev libgstreamer-plugins-base1.0-dev
> >
> >  for cam: [optional]
> > -        libevent-dev
> > +        libevent-dev is required to support cam, however the following
> > +        optional dependencies bring more functionality to the cam test
> 
> functionalty or functionalities ?
> The dictionary I've found says it's both countable and uncountable o_0

Should I use both then ? :-)

According to https://en.wiktionary.org/wiki/functionality, it's
uncountable in the meaning we use here.

> > +        tool:
> > +
> > +        - libdrm-dev: Enables the KMS sink
> > +        - libsdl2-dev: Enables the SDL sink
> > +        - libsdl2-image-dev: Supports MJPEG on the SDL sink
> 
> The content looks good
> Reviewed-by: Jacopo Mondi <jacopo at jmondi.org>
> 
> >
> >  for qcam: [optional]
> >          qtbase5-dev libqt5core5a libqt5gui5 libqt5widgets5 qttools5-dev-tools libtiff-dev

-- 
Regards,

Laurent Pinchart