[libcamera-devel] [PATCH 1/2] qcam: assets: shader: bayer_8.frag: Add precision

[Laurent Pinchart]

Hi Kunal,

Thank you for the patch.

On Mon, Jun 27, 2022 at 08:54:05PM +0530, Kunal Agarwal via libcamera-devel wrote:
> Add precision for data types

This explains what the patch does, but is missing the most important
piece of information: why is this needed ? A word about why you picked
mediump would also be helpful.

https://cbea.ms/git-commit/#why-not-how is a good read when it comes to
how to write good commit messages.

The same applies to patch 2/2.

> Signed-off-by: Kunal Agarwal <kunalagarwal1072002 at gmail.com>
> ---
>  src/qcam/assets/shader/bayer_8.frag | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/src/qcam/assets/shader/bayer_8.frag b/src/qcam/assets/shader/bayer_8.frag
> index 4ece44ab..7e35ca88 100644
> --- a/src/qcam/assets/shader/bayer_8.frag
> +++ b/src/qcam/assets/shader/bayer_8.frag
> @@ -15,6 +15,9 @@ Copyright (C) 2021, Linaro
>  */
>  
>  //Pixel Shader
> +#ifdef GL_ES
> +precision mediump float;
> +#endif
>  
>  /** Monochrome RGBA or GL_LUMINANCE Bayer encoded texture.*/
>  uniform sampler2D       tex_y;

-- 
Regards,

Laurent Pinchart