[libcamera-devel] Pinephone 1.2 and libcamera

Tue Jun 28 12:01:01 CEST 2022

Hi Rafael,

On Tue, Jun 28, 2022 at 06:02:28AM -0300, Rafael Diniz wrote:
> I tried to first just copy the ov5640.c to my 5.15 branch, and the error 
> message from libcamera changed. Now I get:
> 
> WARN CameraSensor camera_sensor.cpp:212 'ov5640 3-004c': Recommended 
> V4L2 control 0x009a0922 not supported
> WARN CameraSensor camera_sensor.cpp:264 'ov5640 3-004c': The sensor 
> kernel driver needs to be fixed
> WARN CameraSensor camera_sensor.cpp:266 'ov5640 3-004c': See 
> Documentation/sensor_driver_requirements.rst in the libcamera sources 
> for more information
> WARN CameraSensor camera_sensor.cpp:411 'ov5640 3-004c': Failed to 
> retrieve the camera location

These can be ignored for now, although it should be easy to fix them by
specifying the camera location (front or back) in the device tree.

> ERROR V4L2 v4l2_videodevice.cpp:1076 /dev/video2[10:cap]: Media bus code 
> filtering not supported by the device
> (this last error repeats more than 50 times ^^^^)
> 
> ERROR SimplePipeline simple.cpp:490 No valid configuration found
> 
> May be I'm missing something in order to backport the ov5640 driver to 
> the 5.15 branch?

It looks like the sun6i-csi is missing the equivalent of the following
commit:

commit 5fc929ae516537720d61139df92fa89ac4989c7b
Author: Dafna Hirschfeld <dafna.hirschfeld at collabora.com>
Date:   Tue Sep 1 13:16:07 2020 +0200

    media: staging: rkisp1: add capability V4L2_CAP_IO_MC to capture devices

> On 6/27/22 05:05, Jacopo Mondi wrote:
> > Hi Rafael,
> > 
> > On Mon, Jun 27, 2022 at 03:46:02AM -0300, Rafael Diniz wrote:
> >> That is wonderful. Thanks for pointing me the OV5640 patches. And before I
> >> start back-porting these patches to my 5.15 branch, is there any git repo I
> >> can clone just to give a first try (with these modifications already
> >> inside)?
> > 
> > I just pushed
> > https://git.sr.ht/~jmondi_/linux/tree/jmondi/media-master/ov5640-v7
> > 
> > which contains the last version of the 5640 patches on top of
> > linux-media master.
> > 
> > Thanks
> >     j
> > 
> >> Rafael
> >>
> >> On 6/26/22 20:29, Laurent Pinchart wrote:
> >>> Hi Rafael,
> >>>
> >>> On Fri, Jun 24, 2022 at 05:24:06AM -0300, Rafael Diniz via libcamera-devel wrote:
> >>>> Hi Jocopo,
> >>>>
> >>>> Thanks. I'm interested to know which kernel version / source people are
> >>>> using to test libcamera on the PinePhone. Indeed, I read all the thread
> >>>> about libcamera in PinePhone in the e-maill archives. "lc-compliance"
> >>>> says drivers I'm using have no proper support for the features needed by
> >>>> libcamera.
> >>>
> >>> Those issues are actually not reported by lc-compliance, but by
> >>> libcamera itself. For the OV5640 camera sensor, the fixes have been
> >>> posted to the linux-media mailing list (see [3], and in particular
> >>> patches 15/28, 16/28 and 21/28), but not merged yet.
> >>>
> >>> The gc2145 driver will need more work.
> >>>
> >>> [3] https://lore.kernel.org/linux-media/20220513141548.6344-1-sakari.ailus@linux.intel.com
> >>>
> >>>> On 6/24/22 04:46, Jacopo Mondi wrote:
> >>>>> Hello Rafael
> >>>>>
> >>>>>      No longer than a few days ago Pavel sent this message
> >>>>> https://lists.libcamera.org/pipermail/libcamera-devel/2022-June/031340.html
> >>>>>
> >>>>> Hope the two of you can synch
> >>>>>
> >>>>> On Thu, Jun 23, 2022 at 04:37:32PM -0300, Rafael Diniz via libcamera-devel wrote:
> >>>>>> Hi everybody,
> >>>>>>
> >>>>>> I'm working on bringing PinePhone cameras support to Maemo-Leste system
> >>>>>> applications, and I opted for libcamera.
> >>>>>>
> >>>>>> I posted some messages here:
> >>>>>> https://github.com/kbingham/libcamera/issues/28
> >>>>>>
> >>>>>> With the kernel 5.15 with pinephone patches [1] imported from Mobian, I get
> >>>>>> some missing features in both cameras drivers [2]. Before I duplicate
> >>>>>> someone's work - did anyone manage to get a kernel which works with current
> >>>>>> libcamera for Pinephone 1 (not the Pro)?
> >>>>>>
> >>>>>> Cheers,
> >>>>>> Rafael
> >>>>>>
> >>>>>> [1] https://github.com/maemo-leste/pine64-kernel/tree/maemo/beowulf-devel
> >>>>>>
> >>>>>> [2] ./lc-compliance
> >>>>>>
> >>>>>> [6:03:22.948763728] [16718] INFO Camera camera_manager.cpp:293 libcamera v0.0.0+3665-bb84fc6a
> >>>>>> [6:03:22.976465603] [16719] WARN CameraSensor camera_sensor.cpp:212 'gc2145 3-003c': Recommended V4L2 control 0x009a0922 not supported
> >>>>>> [6:03:22.978480561] [16719] ERROR V4L2 v4l2_subdevice.cpp:318 'gc2145 3-003c': Unable to get rectangle 2 on pad 0: Inappropriate ioctl for device
> >>>>>> [6:03:22.979363603] [16719] WARN CameraSensor camera_sensor.cpp:239 'gc2145 3-003c': The PixelArraySize property has been defaulted to 1600x1200
> >>>>>> [6:03:22.979433394] [16719] ERROR V4L2 v4l2_subdevice.cpp:318 'gc2145 3-003c': Unable to get rectangle 1 on pad 0: Inappropriate ioctl for device
> >>>>>> [6:03:22.979499686] [16719] WARN CameraSensor camera_sensor.cpp:250 'gc2145 3-003c': The PixelArrayActiveAreas property has been defaulted to (0, 0)/1600x1200
> >>>>>> [6:03:22.979599769] [16719] ERROR V4L2 v4l2_subdevice.cpp:318 'gc2145 3-003c': Unable to get rectangle 0 on pad 0: Inappropriate ioctl for device
> >>>>>> [6:03:22.979663478] [16719] WARN CameraSensor camera_sensor.cpp:258 'gc2145 3-003c': Failed to retrieve the sensor crop rectangle
> >>>>>> [6:03:22.979719186] [16719] WARN CameraSensor camera_sensor.cpp:264 'gc2145 3-003c': The sensor kernel driver needs to be fixed
> >>>>>> [6:03:22.979773644] [16719] WARN CameraSensor camera_sensor.cpp:266 'gc2145 3-003c': See Documentation/sensor_driver_requirements.rst in the libcamera sources for more information
> >>>>>> [6:03:22.979853436] [16719] ERROR CameraSensor camera_sensor.cpp:287 'gc2145 3-003c': Mandatory V4L2 control 0x009e0902 not available
> >>>>>> [6:03:22.979915686] [16719] ERROR CameraSensor camera_sensor.cpp:287 'gc2145 3-003c': Mandatory V4L2 control 0x009f0902 not available
> >>>>>> [6:03:22.979973686] [16719] ERROR CameraSensor camera_sensor.cpp:287 'gc2145 3-003c': Mandatory V4L2 control 0x009e0901 not available
> >>>>>> [6:03:22.980280644] [16719] ERROR CameraSensor camera_sensor.cpp:295 'gc2145 3-003c': The sensor kernel driver needs to be fixed
> >>>>>> [6:03:22.980343811] [16719] ERROR CameraSensor camera_sensor.cpp:297 'gc2145 3-003c': See Documentation/sensor_driver_requirements.rst in the libcamera sources for more information
> >>>>>> [6:03:22.981451561] [16719] ERROR SimplePipeline simple.cpp:1309 No valid pipeline for sensor 'gc2145 3-003c', skipping
> >>>>>> [6:03:22.986176478] [16719] WARN CameraSensor camera_sensor.cpp:212 'ov5640 3-004c': Recommended V4L2 control 0x009a0922 not supported
> >>>>>> [6:03:22.986392019] [16719] ERROR V4L2 v4l2_subdevice.cpp:318 'ov5640 3-004c': Unable to get rectangle 2 on pad 0: Inappropriate ioctl for device
> >>>>>> [6:03:22.986487478] [16719] WARN CameraSensor camera_sensor.cpp:239 'ov5640 3-004c': The PixelArraySize property has been defaulted to 2592x1944
> >>>>>> [6:03:22.986555228] [16719] ERROR V4L2 v4l2_subdevice.cpp:318 'ov5640 3-004c': Unable to get rectangle 1 on pad 0: Inappropriate ioctl for device
> >>>>>> [6:03:22.986618769] [16719] WARN CameraSensor camera_sensor.cpp:250 'ov5640 3-004c': The PixelArrayActiveAreas property has been defaulted to (0, 0)/2592x1944
> >>>>>> [6:03:22.986690769] [16719] ERROR V4L2 v4l2_subdevice.cpp:318 'ov5640 3-004c': Unable to get rectangle 0 on pad 0: Inappropriate ioctl for device
> >>>>>> [6:03:22.986751686] [16719] WARN CameraSensor camera_sensor.cpp:258 'ov5640 3-004c': Failed to retrieve the sensor crop rectangle
> >>>>>> [6:03:22.986807353] [16719] WARN CameraSensor camera_sensor.cpp:264 'ov5640 3-004c': The sensor kernel driver needs to be fixed
> >>>>>> [6:03:22.988926894] [16719] WARN CameraSensor camera_sensor.cpp:266 'ov5640 3-004c': See Documentation/sensor_driver_requirements.rst in the libcamera sources for more information
> >>>>>> [6:03:22.990680353] [16719] ERROR CameraSensor camera_sensor.cpp:287 'ov5640 3-004c': Mandatory V4L2 control 0x009e0902 not available
> >>>>>> [6:03:22.990761353] [16719] ERROR CameraSensor camera_sensor.cpp:287 'ov5640 3-004c': Mandatory V4L2 control 0x009e0901 not available
> >>>>>> [6:03:22.990816561] [16719] ERROR CameraSensor camera_sensor.cpp:295 'ov5640 3-004c': The sensor kernel driver needs to be fixed
> >>>>>> [6:03:22.990869519] [16719] ERROR CameraSensor camera_sensor.cpp:297 'ov5640 3-004c': See Documentation/sensor_driver_requirements.rst in the libcamera sources for more information
> >>>>>> [6:03:22.991348436] [16719] ERROR SimplePipeline simple.cpp:1309 No valid pipeline for sensor 'ov5640 3-004c', skipping

-- 
Regards,

Laurent Pinchart