[libcamera-devel] [PATCH 1/2] libcamera: Add OV2740 camera sensor properties

[Daniel Scally]

Morning Laurent

On 17/03/2022 07:57, Laurent Pinchart wrote:
> On Wed, Mar 16, 2022 at 10:32:31PM +0000, Kieran Bingham via libcamera-devel wrote:
>> Quoting Daniel Scally via libcamera-devel (2022-03-16 22:22:44)
>>> Add camera sensor property entries for the OmniVision 2740 camera
>>> sensor.
>>>
>>> Signed-off-by: Daniel Scally <djrscally at gmail.com>
>>> ---
>>>  src/libcamera/camera_sensor_properties.cpp | 7 +++++++
>>>  1 file changed, 7 insertions(+)
>>>
>>> diff --git a/src/libcamera/camera_sensor_properties.cpp b/src/libcamera/camera_sensor_properties.cpp
>>> index 48305ac4..9bdfd417 100644
>>> --- a/src/libcamera/camera_sensor_properties.cpp
>>> +++ b/src/libcamera/camera_sensor_properties.cpp
>>> @@ -90,6 +90,13 @@ const CameraSensorProperties *CameraSensorProperties::get(const std::string &sen
>>>                                 { controls::draft::TestPatternModePn9, 4 },
>>>                         },
>>>                 } },
>>> +               { "ov2740", {
>>> +                       .unitCellSize = { 1400, 1400 },
>> https://www.ovt.com/wp-content/uploads/2022/01/OV2740-PB-v1.3-WEB.pdf
>> confirms this,
>>
>>> +                       .testPatternModes = {
>>> +                               { controls::draft::TestPatternModeOff, 0 },
>>> +                               { controls::draft::TestPatternModeColorBars, 1},
>> and drivers/media/i2c/ov2740.c confirms this.
> Is this the standard colour bars pattern (as specified in the control
> documentation, referencing the MIPI CCS specification) ?


This mode matches the specification in the control documentation yes
(there are 3 other "color bar" test patterns in the driver that don't
though).

>
>> Reviewed-by: Kieran Bingham <kieran.bingham at ideasonboard.com>
>>
>>> +                       },
>>> +               } },
>>>                 { "ov5647", {
>>>                         .unitCellSize = { 1400, 1400 },
>>>                         .testPatternModes = {},